Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for parsing github-output vars #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added support for parsing github-output vars #67

wants to merge 1 commit into from

Conversation

im-sampm
Copy link
Contributor

@im-sampm im-sampm commented Jan 6, 2024

Closes #66

@shubhbapna shubhbapna self-requested a review January 9, 2024 07:52
shubhbapna
shubhbapna requested changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@shubhbapna shubhbapna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There some test cases failing, could you fix them and I will review it then. Furthermore, can you also write test cases for this?

TWiStErRob
TWiStErRob reviewed Feb 1, 2024
View reviewed changes
src/output-parser/output-parser.ts
* @param line
*/
private parseStepOutputs(line: string) {
const stepOutputsMatcher = /^\s*(\[.+\])\s*\u2699\s*::set-output::\s*(.*)=(.*)/;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, if this gets done, we can generalize it to other side effects, e.g.:

[Android Build/Unit Tests]   ✅  Success - Main Set up Java for Android SDK.
[Android Build/Unit Tests]   ⚙  ::set-env:: JAVA_HOME=/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.10-7/x64
[Android Build/Unit Tests]   ⚙  ::set-env:: JAVA_HOME_17_X64=/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.10-7/x64
[Android Build/Unit Tests]   ⚙  ::set-output:: distribution=Temurin-Hotspot
[Android Build/Unit Tests]   ⚙  ::set-output:: path=/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.10-7/x64
[Android Build/Unit Tests]   ⚙  ::set-output:: version=17.0.10+7
[Android Build/Unit Tests]   ⚙  ::add-path:: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.10-7/x64/bin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#73

@TWiStErRob TWiStErRob mentioned this pull request Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TWiStErRob TWiStErRob TWiStErRob left review comments

@shubhbapna shubhbapna shubhbapna requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing of $GITHUB_OUTPUT variables
4 participants
@im-sampm @TWiStErRob @shubhbapna @im-sampm-demo