Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output of fetch-macOS-v2 more clear. #243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AdityaGarg8
Copy link

The PR makes the logs more readable. Also, fixes a bug where the "Download complete !" line didn't display correctly.

Before:

1. High Sierra (10.13)
2. Mojave (10.14)
3. Catalina (10.15)
4. Big Sur (11.7)
5. Monterey (12.6)
6. Ventura (13) - RECOMMENDED
7. Sonoma (14) 

Choose a product to download (1-7): 6
Downloading 042-23155...
Saving http://oscdn.apple.com/content/downloads/28/14/042-23155/4rscm4lvp3084gutfgpkwj5eex0yyxmzkt/RecoveryImage/BaseSystem.dmg to ./BaseSystem.dmg...
Note: The total download size is 677.99 MB
Download complete!MBs downloaded...     		
Saving http://oscdn.apple.com/content/downloads/28/14/042-23155/4rscm4lvp3084gutfgpkwj5eex0yyxmzkt/RecoveryImage/BaseSystem.chunklist to ./BaseSystem.chunklist...
Note: The total download size is 2740 bytes
Download complete!25 MBs downloaded...  		
Verifying image with chunklist...
Image verification complete!

After:

1. High Sierra (10.13)
2. Mojave (10.14)
3. Catalina (10.15)
4. Big Sur (11.7)
5. Monterey (12.6)
6. Ventura (13) - RECOMMENDED
7. Sonoma (14) 

Choose a product to download (1-7): 6

Downloading 042-23155...

Saving http://oscdn.apple.com/content/downloads/28/14/042-23155/4rscm4lvp3084gutfgpkwj5eex0yyxmzkt/RecoveryImage/BaseSystem.dmg to ./BaseSystem.dmg...

Note: The total download size is 677.99 MB
Download complete!                    

Saving http://oscdn.apple.com/content/downloads/28/14/042-23155/4rscm4lvp3084gutfgpkwj5eex0yyxmzkt/RecoveryImage/BaseSystem.chunklist to ./BaseSystem.chunklist...

Note: The total download size is 2740 bytes
Download complete!                    

Verifying image with chunklist...
Image verification complete!

@kroese
Copy link

kroese commented Jun 9, 2024

I think that file is just an old copy of the original, that lives here: https://github.com/acidanthera/OpenCorePkg/blob/master/Utilities/macrecovery/macrecovery.py

So if you want to submit improvements, it might be better to submit them to the upstream repository.

@AdityaGarg8
Copy link
Author

I think that file is just an old copy of the original, that lives here: https://github.com/acidanthera/OpenCorePkg/blob/master/Utilities/macrecovery/macrecovery.py

So if you want to submit improvements, it might be better to submit them to the upstream repository.

Upstream already has it improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants