build: add root project name (#580)

Co-authored-by: khalilou88 <[email protected]>
khalilou88 · Nov 5, 2023 · 61a28e3 · 61a28e3
1 parent 1b6fdeb
commit 61a28e3
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 4 deletions.
diff --git a/packages/create-nx-gradle-workspace/bin/index.ts b/packages/create-nx-gradle-workspace/bin/index.ts
@@ -53,6 +53,17 @@ async function main() {
     ).dsl;
   }
 
+  let rootProjectName = '';
+  if (!args['rootProjectName']) {
+    rootProjectName = (
+      await prompt<{ rootProjectName: string }>({
+        type: 'input',
+        name: 'rootProjectName',
+        message: 'What rootProjectName would you like to use?',
+      })
+    ).rootProjectName;
+  }
+
   let gradleRootDirectory = '';
   if (!args['gradleRootDirectory']) {
     gradleRootDirectory = (
@@ -107,7 +118,7 @@ async function main() {
       //init generator
       javaVersion,
       dsl,
-      rootProjectName: name,
+      rootProjectName,
       gradleRootDirectory,
       preset,
       skipWrapper: false,

diff --git a/packages/create-nx-maven-workspace/bin/index.ts b/packages/create-nx-maven-workspace/bin/index.ts
@@ -47,6 +47,17 @@ async function main() {
     ).groupId;
   }
 
+  let parentProjectName = '';
+  if (!args['parentProjectName']) {
+    parentProjectName = (
+      await prompt<{ parentProjectName: string }>({
+        type: 'input',
+        name: 'parentProjectName',
+        message: 'What parentProjectName would you like to use?',
+      })
+    ).parentProjectName;
+  }
+
   let parentProjectVersion = '';
   if (!args['parentProjectVersion']) {
     parentProjectVersion = (
@@ -118,7 +129,7 @@ async function main() {
       //init generator
       javaVersion,
       groupId,
-      parentProjectName: name,
+      parentProjectName,
       parentProjectVersion,
       mavenRootDirectory,
       dependencyManagement,

diff --git a/testing-projects/jnxplus-e2e/tests/nx-gradle/create-nx-gradle-workspace.spec.ts b/testing-projects/jnxplus-e2e/tests/nx-gradle/create-nx-gradle-workspace.spec.ts
@@ -16,7 +16,7 @@ describe('create-nx-gradle-workspace', () => {
   it('should be installed', () => {
     workspaceDirectory = createTestWorkspaceWithCustomCli(
       'create-nx-gradle-workspace',
-      '--javaVersion 21 --dsl kotlin --gradleRootDirectory test --preset micronaut',
+      '--javaVersion 21 --dsl kotlin --rootProjectName root-project --gradleRootDirectory test --preset micronaut',
     );
 
     // npm ls will fail if the package is not installed properly

diff --git a/testing-projects/jnxplus-e2e/tests/nx-maven/create-nx-maven-workspace.spec.ts b/testing-projects/jnxplus-e2e/tests/nx-maven/create-nx-maven-workspace.spec.ts
@@ -16,7 +16,7 @@ describe('create-nx-maven-workspace', () => {
   it('should be installed', () => {
     workspaceDirectory = createTestWorkspaceWithCustomCli(
       'create-nx-maven-workspace',
-      '--javaVersion 17 --groupId com.example --parentProjectVersion 0.0.0 --mavenRootDirectory test --dependencyManagement spring-boot-parent-pom',
+      '--javaVersion 17 --groupId com.example --parentProjectName root-project --parentProjectVersion 0.0.0 --mavenRootDirectory test --dependencyManagement spring-boot-parent-pom',
     );
 
     // npm ls will fail if the package is not installed properly