feat: add skipFormat option (#1333)

khalilou88 · Oct 10, 2024 · 3b497fb · 3b497fb
1 parent bf1bdd2
commit 3b497fb
Show file tree

Hide file tree

Showing 27 changed files with 81 additions and 9 deletions.
diff --git a/packages/nx-gradle/src/generators/application/generator.ts b/packages/nx-gradle/src/generators/application/generator.ts
@@ -454,5 +454,7 @@ async function applicationGenerator(
 
   addFiles(tree, normalizedOptions);
   addProjectToGradleSetting(tree, normalizedOptions);
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 }
diff --git a/packages/nx-gradle/src/generators/application/schema.d.ts b/packages/nx-gradle/src/generators/application/schema.d.ts
@@ -14,4 +14,5 @@ export interface NxGradleAppGeneratorSchema {
   minimal?: boolean;
   port?: string | number;
   framework?: FrameworkType;
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-gradle/src/generators/application/schema.json b/packages/nx-gradle/src/generators/application/schema.json
@@ -134,6 +134,11 @@
       ],
       "default": 8080,
       "description": "Port to start the server at. Default is 8080."
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": ["name", "language", "groupId", "projectVersion", "configFormat"]

diff --git a/packages/nx-gradle/src/generators/init/generator.ts b/packages/nx-gradle/src/generators/init/generator.ts
@@ -144,7 +144,9 @@ export async function initGenerator(
       '755',
     );
   }
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 
   return () => {
     installPackagesTask(tree);

diff --git a/packages/nx-gradle/src/generators/init/schema.d.ts b/packages/nx-gradle/src/generators/init/schema.d.ts
@@ -8,4 +8,5 @@ export interface NxGradleInitGeneratorSchema {
   preset: PresetType;
   skipWrapper?: boolean;
   versionManagement: VersionManagementType;
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-gradle/src/generators/init/schema.json b/packages/nx-gradle/src/generators/init/schema.json
@@ -112,6 +112,11 @@
           }
         ]
       }
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": [

diff --git a/packages/nx-gradle/src/generators/library/generator.ts b/packages/nx-gradle/src/generators/library/generator.ts
@@ -335,5 +335,7 @@ async function libraryGenerator(
   addFiles(tree, normalizedOptions);
   addProjectToGradleSetting(tree, normalizedOptions);
   addLibraryToProjects(tree, normalizedOptions);
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 }
diff --git a/packages/nx-gradle/src/generators/library/schema.d.ts b/packages/nx-gradle/src/generators/library/schema.d.ts
@@ -12,4 +12,5 @@ export interface NxGradleLibGeneratorSchema {
   projects?: string;
   skipStarterCode?: boolean;
   framework?: FrameworkType;
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-gradle/src/generators/library/schema.json b/packages/nx-gradle/src/generators/library/schema.json
@@ -101,6 +101,11 @@
       "description": "Skip starter code",
       "type": "boolean",
       "default": false
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": ["name", "language", "groupId", "projectVersion"]

diff --git a/packages/nx-gradle/src/generators/wrapper/generator.ts b/packages/nx-gradle/src/generators/wrapper/generator.ts
@@ -56,7 +56,9 @@ export default async function (
     joinPathFragments(normalizedOptions.gradleRootDirectory, 'gradlew.bat'),
     '755',
   );
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 }
 
 export function updateGitIgnore(tree: Tree) {

diff --git a/packages/nx-gradle/src/generators/wrapper/schema.d.ts b/packages/nx-gradle/src/generators/wrapper/schema.d.ts
@@ -1,3 +1,4 @@
 export interface NxGradleWrapperGeneratorSchema {
   skipGitignore?: boolean;
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-gradle/src/generators/wrapper/schema.json b/packages/nx-gradle/src/generators/wrapper/schema.json
@@ -8,6 +8,11 @@
       "description": "Don't add Gradle Wrapper to .gitignore",
       "type": "boolean",
       "default": false
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": []

diff --git a/packages/nx-maven/src/generators/application/generator.ts b/packages/nx-maven/src/generators/application/generator.ts
@@ -489,5 +489,7 @@ async function applicationGenerator(
     aggregatorProject: normalizedOptions.aggregatorProject,
     mavenRootDirectory: normalizedOptions.mavenRootDirectory,
   });
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 }
diff --git a/packages/nx-maven/src/generators/application/schema.d.ts b/packages/nx-maven/src/generators/application/schema.d.ts
@@ -16,4 +16,5 @@ export interface NxMavenAppGeneratorSchema {
   minimal?: boolean;
   port?: string | number;
   framework?: FrameworkType;
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-maven/src/generators/application/schema.json b/packages/nx-maven/src/generators/application/schema.json
@@ -144,6 +144,11 @@
       ],
       "default": 8080,
       "description": "Port to start the server at. Default is 8080."
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": [

diff --git a/packages/nx-maven/src/generators/init/generator.ts b/packages/nx-maven/src/generators/init/generator.ts
@@ -120,7 +120,9 @@ export async function initGenerator(
       '755',
     );
   }
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 
   return () => {
     installPackagesTask(tree);

diff --git a/packages/nx-maven/src/generators/init/schema.d.ts b/packages/nx-maven/src/generators/init/schema.d.ts
@@ -9,4 +9,5 @@ export interface NxMavenInitGeneratorSchema {
   dependencyManagement: DependencyManagementType;
   skipWrapper?: boolean;
   localRepoRelativePath: string;
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-maven/src/generators/init/schema.json b/packages/nx-maven/src/generators/init/schema.json
@@ -86,6 +86,11 @@
       "type": "string",
       "description": "Maven local repository relative path to {workspaceRoot}/{mavenRootDirectory}",
       "default": ".m2/repository"
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": [

diff --git a/packages/nx-maven/src/generators/library/generator.ts b/packages/nx-maven/src/generators/library/generator.ts
@@ -340,5 +340,7 @@ async function libraryGenerator(
     mavenRootDirectory: normalizedOptions.mavenRootDirectory,
   });
   addLibraryToProjects(tree, normalizedOptions);
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 }
diff --git a/packages/nx-maven/src/generators/library/schema.d.ts b/packages/nx-maven/src/generators/library/schema.d.ts
@@ -14,4 +14,5 @@ export interface NxMavenLibGeneratorSchema {
   projects?: string;
   skipStarterCode?: boolean;
   framework?: FrameworkType;
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-maven/src/generators/library/schema.json b/packages/nx-maven/src/generators/library/schema.json
@@ -111,6 +111,11 @@
       "description": "Skip starter code",
       "type": "boolean",
       "default": false
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": ["name", "language", "groupId", "projectVersion", "parentProject"]

diff --git a/packages/nx-maven/src/generators/parent-project/generator.ts b/packages/nx-maven/src/generators/parent-project/generator.ts
@@ -191,5 +191,7 @@ async function parentProjectGenerator(
     aggregatorProject: normalizedOptions.aggregatorProject,
     mavenRootDirectory: normalizedOptions.mavenRootDirectory,
   });
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 }
diff --git a/packages/nx-maven/src/generators/parent-project/schema.d.ts b/packages/nx-maven/src/generators/parent-project/schema.d.ts
@@ -12,4 +12,5 @@ export interface NxMavenParentProjectGeneratorSchema {
   aggregatorProject?: string;
   framework?: FrameworkType;
   language: 'java' | 'kotlin' | 'java-kotlin';
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-maven/src/generators/parent-project/schema.json b/packages/nx-maven/src/generators/parent-project/schema.json
@@ -104,6 +104,11 @@
     "aggregatorProject": {
       "type": "string",
       "description": "ArtifactId of the aggregator project (that manages a group of submodules) or leave it blank for the root project"
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": ["name", "projectType", "groupId", "projectVersion"]

diff --git a/packages/nx-maven/src/generators/wrapper/generator.ts b/packages/nx-maven/src/generators/wrapper/generator.ts
@@ -60,7 +60,9 @@ export default async function (
     joinPathFragments(normalizedOptions.mavenRootDirectory, 'mvnw.cmd'),
     '755',
   );
-  await formatFiles(tree);
+  if (!options.skipFormat) {
+    await formatFiles(tree);
+  }
 }
 
 function updateGitIgnore(tree: Tree) {

diff --git a/packages/nx-maven/src/generators/wrapper/schema.d.ts b/packages/nx-maven/src/generators/wrapper/schema.d.ts
@@ -1,3 +1,4 @@
 export interface NxMavenWrapperGeneratorSchema {
   skipGitignore?: boolean;
+  skipFormat?: boolean;
 }
diff --git a/packages/nx-maven/src/generators/wrapper/schema.json b/packages/nx-maven/src/generators/wrapper/schema.json
@@ -8,6 +8,11 @@
       "description": "Don't add Maven Wrapper to .gitignore",
       "type": "boolean",
       "default": false
+    },
+    "skipFormat": {
+      "description": "Skip formatting files.",
+      "type": "boolean",
+      "default": false
     }
   },
   "required": []