Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettyprint/produce proof tree #43

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Prettyprint/produce proof tree #43

wants to merge 7 commits into from

Conversation

nishantjr
Copy link
Member

@nishantjr nishantjr commented Feb 11, 2020

This PR adds a script called lib/render-proof-tree that pretty prints the proof tree and the current/selected goal.

It also changes sequential composition to occur within a subgoal. Performance doesn't seem to have been affected much, but I have not tested that extensively.

@nishantjr nishantjr force-pushed the detailed-proofs branch 2 times, most recently from 507cb90 to 9a6889d Compare April 20, 2020 17:46
@nishantjr nishantjr changed the title [draft] Leave behind a proof-tree on success Leave behind a proof-tree on success Apr 20, 2020
@nishantjr nishantjr changed the title Leave behind a proof-tree on success Prettyprint/produce proof tree Apr 20, 2020
@nishantjr
Copy link
Member Author

I have run the smoke test and things work. Please run any other tests you are concerned about

Copy link
Collaborator

@xc93 xc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR.

Copy link
Contributor

@lucaspena lucaspena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is it possible to have tests for either this or reap? Unit tests may be impossible but just some regular input output perhaps?

@nishantjr
Copy link
Member Author

Looks good. Is it possible to have tests for either this or reap? Unit tests may be impossible but just some regular input output perhaps?

Thats an idea. Right now the tests are timing out. It looks like Xiaohong is right, and there is a performance issue. I've pushed a PR that reduces changes the set of goals to a list, and only considers the first goal as active. I'll need to re-implement #reap in that context.

@nishantjr nishantjr force-pushed the detailed-proofs branch 2 times, most recently from b853c84 to 2491890 Compare April 22, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants