-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the API configuration modular #861
base: master
Are you sure you want to change the base?
Conversation
2f506b4
to
5deb1f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5deb1f9
to
31f51c6
Compare
31f51c6
to
7f5d918
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, just would like to have someone else that has more experince with actix to also take a look at it.
Move the /keys scope configuration from main to the keys_handler module. This is a preparation to support multiple API versions. Also, make the methods that are not required outside of the module private. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Move the /quotes scope configuration from main to quotes_handler module. This is a preparation to support multiple API versions. Also, make the methods that are not required outside the module private. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Move the /notifications scope configuration from main to notifications_handler. This is a preparation to support multiple API versions. Also, restrict the visibility of methods that are not required outside the module to private. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Move the /agent scope configuration from main to agent_handler. This is a preparation to support multiple API versions. Also, restrict the visibility of methods that are not required outside the module to private. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
Move the API configuration to a dedicated file and make it modular. The API configuration is separated for each supported version. Currently only the latest API version (v2.2) is supported. This is a preparation to support multiple API versions. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
7f5d918
to
9e528f1
Compare
/packit retest-failed |
Move the configuration of the API for each scope into the respective handler file.
Also, move the API configuration into a dedicated file, and make it modular.
This is a preparation to add support for multiple API versions.