tpm: Overhaul errors #711
Merged
tpm: Overhaul errors #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make get_idevid_template() to return TpmError Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
ansasaki
force-pushed
the
overhaul_errors
branch
from
816926e
to
30ed004
Compare
ansasaki
force-pushed
the
overhaul_errors
branch
3 times, most recently
from
f2edf71
to
b4d72e7
Compare
Add granular error types for every possible error raised by the tpm module. This improves diagnosing the cause of the errors without showing complex errors coming from underlying libraries. This also drops all 'expect()` and `unwrap()` uses to avoid panicking. Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
ansasaki
force-pushed
the
overhaul_errors
branch
from
b4d72e7
to
e0ba2f8
Compare
Codecov ReportAttention:
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aplanas
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add granular error types for every possible error raised by the
tpmmodule. This improves diagnosing the cause of the errors without showing complex errors coming from underlying libraries.This also drops all
expect()andunwrap()uses to avoid panicking.Fixes: #330, #639