Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: Bump serde to version 1.0.188 #662

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

ansasaki
Copy link
Contributor

Supersedes #631

@aplanas
Copy link
Contributor

aplanas commented Sep 27, 2023

What can be the timeout from the Rust / Fedora test?

@ansasaki
Copy link
Contributor Author

What can be the timeout from the Rust / Fedora test?

That is a tarpaulin (test coverage measurement) issue dealing with parallel processing. The last time I investigated it , it was related with this open issue: xd009642/tarpaulin#971. It happens from time to time and it is annoying. Most of the time a re-run makes the test to pass.

Maybe we could try to use the option they recommend there --engine llvm and see if it improves the situation.

@aplanas
Copy link
Contributor

aplanas commented Sep 27, 2023

There is also this related with tarpaulin in testing-farm:fedora-37:

:: [ 09:30:13 ] :: [  BEGIN   ] :: Running 'cargo tarpaulin -v --target-dir target/tarpaulin --workspace --exclude-files 'target/*' --ignore-panics --ignore-tests --out Xml --out Html --all-features'

error: unexpected argument '-v' found

Seems that the cli changed, maybe after an update

@aplanas
Copy link
Contributor

aplanas commented Sep 27, 2023

Ah ... related: xd009642/tarpaulin#1389

@ansasaki
Copy link
Contributor Author

There is also this related with tarpaulin in testing-farm:fedora-37:

:: [ 09:30:13 ] :: [  BEGIN   ] :: Running 'cargo tarpaulin -v --target-dir target/tarpaulin --workspace --exclude-files 'target/*' --ignore-panics --ignore-tests --out Xml --out Html --all-features'

error: unexpected argument '-v' found

Seems that the cli changed, maybe after an update

Yes, we are aware of this, thank you for checking anyway!

They accidentally dropped the -v option on the latest release. The option was restored upstream, but not released yet.
See: xd009642/tarpaulin#1389

@ansasaki
Copy link
Contributor Author

There is also this related with tarpaulin in testing-farm:fedora-37:

:: [ 09:30:13 ] :: [  BEGIN   ] :: Running 'cargo tarpaulin -v --target-dir target/tarpaulin --workspace --exclude-files 'target/*' --ignore-panics --ignore-tests --out Xml --out Html --all-features'

error: unexpected argument '-v' found

Seems that the cli changed, maybe after an update

Yes, we are aware of this, thank you for checking anyway!

They accidentally dropped the -v option on the latest release. The option was restored upstream, but not released yet. See: xd009642/tarpaulin#1389

BTW, I think I'll fix this (by using the long option) and also try using the --engine llvm in a separate PR.

@ansasaki
Copy link
Contributor Author

Opened #663

Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
@ansasaki ansasaki merged commit d621d9e into keylime:master Sep 28, 2023
7 of 9 checks passed
@ansasaki ansasaki deleted the bump-serde branch September 28, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants