Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create bundle to enable operator-sdk deployment #53

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Create bundle to enable operator-sdk deployment #53

merged 1 commit into from
Feb 8, 2024

Conversation

sarroutbi
Copy link
Collaborator

Resolves: #52

This was referenced Jan 29, 2024
Closed
Open
@sarroutbi sarroutbi force-pushed the 202401241115-attestation-operator-bundle branch 5 times, most recently from e855ccb to f067fd5 Compare January 31, 2024 12:48
@sarroutbi
Copy link
Collaborator Author

sarroutbi commented Jan 31, 2024 •
edited
Loading

I had to add a secret named keylime-swtpm-cert-store for the controller to run appropriately. After doing so, controller can be deployed additionally through operator-sdk, although previous deployment mechanisms have been untouched.

However, this is common also for the "non bundle" version, so IMHO this is ready to be merged.

Information added to README.md on how to deploy through operator-sdk has also been added

@sarroutbi sarroutbi marked this pull request as ready for review January 31, 2024 12:58
@sarroutbi sarroutbi changed the title WIP: Create bundle to enable operator-sdk deployment Create bundle to enable operator-sdk deployment Jan 31, 2024
@galmasi
Copy link

galmasi commented Feb 1, 2024

@sarroutbi i just posted #65 to make the controller helm deployment defaults match secret names used by the rest of the keylime deployment.

@sarroutbi sarroutbi force-pushed the 202401241115-attestation-operator-bundle branch from f067fd5 to f0e5ff0 Compare February 6, 2024 15:20
@sarroutbi sarroutbi force-pushed the 202401241115-attestation-operator-bundle branch from f0e5ff0 to 0c206f5 Compare February 6, 2024 15:31
@sarroutbi
Copy link
Collaborator Author

After rebasing this PR with code in #65 , it started working appropriately with no requirement to create a secret manually. Bundle has been updated accordingly

@maugustosilva maugustosilva self-requested a review February 8, 2024 16:48
@maugustosilva
Copy link
Contributor

Since it does not affect the deployment of the controller via helm, I am merging it now. We will keep refining it in subsequent PRs.

@maugustosilva maugustosilva merged commit b9cc020 into keylime:main Feb 8, 2024
2 checks passed
@sarroutbi sarroutbi deleted the 202401241115-attestation-operator-bundle branch March 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maugustosilva maugustosilva maugustosilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include mechanism to deploy controller through bundle to be able to deploy controller through operator-sdk
3 participants
@sarroutbi @galmasi @maugustosilva