Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some material definitions for ILD models #404

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Fix some material definitions for ILD models #404

merged 5 commits into from
Oct 25, 2024

Conversation

danieljeans
Copy link
Contributor

@danieljeans danieljeans commented Oct 17, 2024 •
edited by tmadlener
Loading

BEGINRELEASENOTES

  • fix some inconsistent definitions of materials used in ILD simulation (sum of fractions != 1.000)
  • adjust composition of RPC gas to R134a:0.93 + CO2:0.05 + SF6:0.02 [exchange 5% isoButane for CO2, as suggested by G. Grenier]

ENDRELEASENOTES

@tmadlener
Copy link
Contributor

Does this have any implications for the final physics?

@danieljeans
Copy link
Contributor Author

it should be completely negligible.

@tmadlener tmadlener enabled auto-merge (squash) October 25, 2024 09:31
@tmadlener tmadlener merged commit 1558cdb into key4hep:main Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieljeans @tmadlener