Patch on ECalBarrelInclined_geo.cpp for adding Material Manager #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
reviewed
Aug 21, 2023
BrieucF
reviewed
Aug 24, 2023
There was a problem hiding this comment.
What about using CLD_o4_v01?
There was a problem hiding this comment.
I have used CLD_o4_V05. The version is updated for review. The LAr bath still has overlap with the readouts and absorbers. Maybe someone from LAr department can sort this out? Everything else is overlap free.
There was a problem hiding this comment.
Why not start with v01 since it is the first version of this "option 4"?
Can you also add a line or two in FCCee/CLD/compact/README.md to explain in what this option differs from the others and to tell which CLD_oX_vY was used as a starting point?
SwathiSasikumar
force-pushed
the
master
branch
2 times, most recently
from
bcc00fc
to
1a708a9
Compare
andresailer
reviewed
Sep 12, 2023
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
andresailer
reviewed
Oct 31, 2023
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
andresailer
reviewed
Oct 31, 2023
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Outdated
Show resolved
Hide resolved
andresailer
reviewed
Oct 31, 2023
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v01_geo.cpp
Show resolved
Hide resolved
BrieucF
reviewed
Nov 2, 2023
BrieucF
reviewed
Nov 7, 2023
SwathiSasikumar
force-pushed
the
master
branch
from
7889194
to
3e58bdb
Compare
andresailer
reviewed
Nov 8, 2023
andresailer
reviewed
Nov 8, 2023
BrieucF
reviewed
Nov 9, 2023
|
What's left to do here @SwathiSasikumar? |
|
@jmcarcell With whatever we know currently there is nothing more to add right now. It looks complete. At a later point, the cell size needs to be updated but that part might take time and can be done for the next release. |
Adding the usage of ```MaterialManager``` and ``` LayeredCalorimeterData``` to obtain calorimeter information like Radiation length, interaction length etc. The values of inner thickness, sensitive thickness, outer thickness and absorber thickness has a dummy value temporarily which will be changed.
…imensions. Add materials needed for the LAr There however are overlaps inside of LAr bath which experts on LAr should maybe take care of
…_o1_v01_geo.cpp Co-authored-by: Andre Sailer <[email protected]>
…_o1_v01_geo.cpp Co-authored-by: Andre Sailer <[email protected]>
…_o1_v01_geo.cpp Co-authored-by: Andre Sailer <[email protected]>
…_o1_v01_geo.cpp Co-authored-by: Andre Sailer <[email protected]>
…_o1_v01_geo.cpp Co-authored-by: Andre Sailer <[email protected]>
push_back all layers to keep them for later
… radially which was along the inclined electrode.
Co-authored-by: Andre Sailer <[email protected]>
Co-authored-by: Andre Sailer <[email protected]>
Change from system:4 to system:5
|
Then I'll let @andresailer merge; I've just rebased and the CI should be happy |
andresailer
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ECalBarrelInclined_geo: Implemented filling of the LayeredCalorimeterData extension, which now allows reconstruction of clusters by PandoraPFA. The detector geometry compact files used for the reconstruction are added in
CLD_o4_v05.ENDRELEASENOTES