Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IDEA_o1_v02 and its vertex detector #273

Merged
merged 73 commits into from
Oct 3, 2023

Commits on Jul 17, 2023

  1. Adding module functionality to ZPlanarTracker_geo

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8d465f5 View commit details
    Browse the repository at this point in the history
  2. Leaving ZPlanarTracker as it is but instead make a new VertexBarrel_o…

    …1_v01_geo module
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c00f642 View commit details
    Browse the repository at this point in the history
  3. Added ability to have flex and support consisting of multiple compone…

    …nts, ability to tilt whole modules.
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    640115c View commit details
    Browse the repository at this point in the history
  4. First implementation of IDEA end-cap and adaption of barrel

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    f259579 View commit details
    Browse the repository at this point in the history
  5. Version of Barrel with correct sensitive surfaces (use teveDisplay to…

    … show them)
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    fa1d847 View commit details
    Browse the repository at this point in the history
  6. Improved structure of barrel detectors (layer - ladder+sensors)

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6061af7 View commit details
    Browse the repository at this point in the history
  7. Progress: The surface arrows are now displayed in the endcap, but the…

    … volumes not yet
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6d6af32 View commit details
    Browse the repository at this point in the history
  8. Whole barrel is properly visible in teveDisplay, but don't mange to m…

    …ake good assembly structure
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e69ee1d View commit details
    Browse the repository at this point in the history
  9. Also endcap shows all volumes in teveDisplay, but bad hierarchy

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    012de49 View commit details
    Browse the repository at this point in the history
  10. Endcap and barrel now run through ddsim overlap checker (overlaps sti…

    …ll there)
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e165a35 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    cc2656d View commit details
    Browse the repository at this point in the history
  12. Not working teveDisplay, endcap digitisation not working probably the…

    …refore
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    dee4d5a View commit details
    Browse the repository at this point in the history
  13. Fixed endcap, all surfaces visible in teveDisplay, managed to run dds…

    …im and fccRec_e4h with vertex digitisation, but no vertices reco'd yet, bad hierarchy again
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    1a22125 View commit details
    Browse the repository at this point in the history
  14. Non-working version, the sensitive volumes are wrong, no idea why, us…

    …e the previous commit
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e08ea1e View commit details
    Browse the repository at this point in the history
  15. Bad hierarchy, but otherwise working

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    a8c19ec View commit details
    Browse the repository at this point in the history
  16. Found way to remove mother volumes in sensitive and passives. Now all…

    … overlaps in Endcap gone
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c8eef55 View commit details
    Browse the repository at this point in the history
  17. Removing unneeded lines

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    f27a485 View commit details
    Browse the repository at this point in the history
  18. Recomputing bounding boxes, hasn't fixed the problem yet

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ce6e9ec View commit details
    Browse the repository at this point in the history
  19. Adding IDEA as FCCee_IDEA_o1_v01, not final yet, need to make sure th…

    …at latest beam pipe and other files are used. There's also still an overlap between the CAD-imported vertex support and the vertex barrel
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    a19cad2 View commit details
    Browse the repository at this point in the history
  20. Adding again deleted file

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ca514ec View commit details
    Browse the repository at this point in the history
  21. Reverting changes to VertexBarrel_o1_v01_geo.cpp

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    23113db View commit details
    Browse the repository at this point in the history
  22. Adding scripts

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    82c7996 View commit details
    Browse the repository at this point in the history
  23. Addressing comments from MR, adding some tests for DDCAD files

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    a7b9a86 View commit details
    Browse the repository at this point in the history
  24. Add DDCAD test

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b250bb3 View commit details
    Browse the repository at this point in the history
  25. Adding test

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    30e7504 View commit details
    Browse the repository at this point in the history
  26. Renamed constructor files

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6099720 View commit details
    Browse the repository at this point in the history
  27. Adapting dd4hep::CellID instead of long64

    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b4b5df0 View commit details
    Browse the repository at this point in the history
  28. Changing naming convention to Vertex inner barrel, vertex outer barre…

    …l and vertex disks, adding working DDCAD import of vertex inner barrel support (using material budget estimation from FCCSW not working yet though, need to use g4MaterialScan). Adding example on how I install k4geo locally (install.sh)
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    67e3925 View commit details
    Browse the repository at this point in the history
  29. SingleShape_geo not needed for DDCAD import, instead using DD4hep_Tes…

    …tShape_Creator from DD4hep
    Armin Fehr authored and armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    2ca7981 View commit details
    Browse the repository at this point in the history
  30. Changing CAD shape name

    armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    81e6f96 View commit details
    Browse the repository at this point in the history
  31. Adding all plotting scripts

    armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9bfa40e View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    4060e59 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    281a350 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    970ce38 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    7c32aa9 View commit details
    Browse the repository at this point in the history
  36. Fixed some paths

    armin-ilg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c450cb2 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Testing test...

    armin-ilg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    a9f7870 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ef98c8 View commit details
    Browse the repository at this point in the history
  3. Fixing test

    armin-ilg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    9242186 View commit details
    Browse the repository at this point in the history
  4. Using .obj file for Vertex inner barrel support instead of .stl, runn…

    …ing now without Geant4 exceptions
    armin-ilg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2ab05fa View commit details
    Browse the repository at this point in the history
  5. Adding back hierarchy of vertex detector elements, visualisation does…

    … not work in teveDisplay (for the whole vertex) or in geoDisplay (for the disks), but is working when using scripts/build_view.sh
    armin-ilg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    51c43e8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0ef86c7 View commit details
    Browse the repository at this point in the history
  7. Fix simulate script

    armin-ilg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    cb4a8bf View commit details
    Browse the repository at this point in the history
  8. ATLASPix3 modules were 90 degrees rotated, now fixed. Furthermore wro…

    …ng distance between individual chips fixed
    armin-ilg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    c7303cb View commit details
    Browse the repository at this point in the history
  9. Removing unnecessary line

    armin-ilg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e1c3160 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    48dfd8f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Reducing hierarchy by one level in the endcaps, so that it's visible …

    …in geoDisplay. Apparently three levels of hierarchy of assemblies is the limit, otherwise geoDisplay will not show the volumes. It is not working in teveDisplay however
    armin-ilg committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    43c81c6 View commit details
    Browse the repository at this point in the history
  2. Fixing physVolIDs

    armin-ilg committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2a9a9af View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from armin-ilg/test

    Fixing test (.obj instead of .stl file), adding hierarchy to vertex detector volumes, fix orientation of ATLASPix3 modules
    armin-ilg authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4551275 View commit details
    Browse the repository at this point in the history
  4. Small script fixes

    armin-ilg committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7496661 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    49eb21a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7914eb0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b1bd08 View commit details
    Browse the repository at this point in the history
  4. Found another way to get the correct paths for the scripts, using /cv…

    …mfs/sw-nightlies.hsf.org/key4hep/releases/2023-07-22/x86_64-centos7-gcc12.2.0-opt/k4geo/1c08affe597cf3b1c10c4e81cdbc95ab9e4a4d23=develop-q7e4mj/share/k4geo/compact for the DDCAD import in Vertex_IDEA_o1_v01.xml, should work once merged and added to the key4hep nightly
    armin-ilg committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d37be7e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    de5c1ef View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Configuration menu
    Copy the full SHA
    81cddf1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b09858a View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Configuration menu
    Copy the full SHA
    fb1b591 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab80327 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    17bcdf3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9d61c8e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Renaming beampipe to match with CLD beampipe (identical at the moment…

    …, change name when they differ)
    armin-ilg committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d66a05d View commit details
    Browse the repository at this point in the history
  2. Fixing test and have correct name for beampipe also in main xml file.…

    … The test will only run once the IDEA folder is in the nightly Key4hep software stack
    armin-ilg committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    3693833 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfcaf04 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Moved volume creation within main part of program, so that correct vo…

    …lume names can be assigned. Furthermore changed DetElements in barrel constructor so that they can be properly accessed in k4RecTracker
    armin-ilg committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    11d1105 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Added functionality to have end of stave structures in vertex barrel.…

    … This is applied in the IDEA vertex detector. Other than this, also the width of the sensor support in the vertex barrel was corrected to be only 4.4 mm wide (instead of 8.8)
    armin-ilg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    6a4c536 View commit details
    Browse the repository at this point in the history
  2. Added end-of-stave structures or proxies as well for the outer barrel…

    …, only end-cap missing
    armin-ilg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    7646e21 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13554da View commit details
    Browse the repository at this point in the history
  4. Unified description of readout and support structures, now called com…

    …ponents. Multiple components can be added per stave and the name will be used to name the corresponding assembly. Furthermore fixed the sensitive/periphery regions in VTXIB layers 2 and 3 to be correct
    armin-ilg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c07d81c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    aa26ee6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eafb798 View commit details
    Browse the repository at this point in the history
  3. Fixing test and for the moment comment out the vertex inner barrel su…

    …pport as it will fail the test, since the CAD file cannot be found. After the IDEA detector is in a nightly release, then the CAD file will be found and we can include these lines in the xml again
    armin-ilg committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    406a3f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Changing to IDEA_o1_v02

    armin-ilg committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    d149e7e View commit details
    Browse the repository at this point in the history