New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a comment and check for the status code of a test #137

Merged

andresailer merged 2 commits into main from fixes

Sep 5, 2023

Contributor

jmcarcell commented Sep 4, 2023 •

edited by andresailer

Loading

BEGINRELEASENOTES

Docs: Correct the comment referring to the input file that has to be replaced
Test: no longer ignore the return value of a test. It used to return 4, but that was fixed in k4run: return exit code 0 if -n -1 was used and Gaudi returned exit code 4 k4FWCore#132
Tests: Replace environment variable LCGEO with K4GEO following the usage in other key4hep repositories

ENDRELEASENOTES

The line that was previously going to be substituted doesn't exist. There is an extra place where LCGEO appears: https://github.com/key4hep/k4MarlinWrapper/blob/main/doc/starterkit/k4MarlinWrapperCLIC/Readme.md?plain=1#L118
but that also requires changes in CLICPerformance/clicConfig

jmcarcell added 2 commits

September 4, 2023 17:29


          Fix a comment and check for the status code of a test

202b00a


          Change LCGEO to K4GEO

5054eed

Collaborator

andresailer commented Sep 4, 2023

Please put in more context for "Change LCGEO to K4GEO"

andresailer approved these changes

View reviewed changes

andresailer merged commit 3c06536 into main

10 of 13 checks passed

andresailer deleted the fixes branch

September 5, 2023 08:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet