Only link to libraries that are actually needed #133
Closed
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresailer
reviewed
Aug 3, 2023
| @@ -27,7 +27,7 @@ gaudi_add_module(k4MarlinWrapperPlugins | |||
| src/components/LcioEventOutput.cpp | |||
| LINK | |||
| Gaudi::GaudiAlgLib | |||
| ${Marlin_LIBRARIES} | |||
| Marlin | |||
There was a problem hiding this comment.
This just makes cmake add -lMarlin, so you would have to add -L /path/to/marlin/lib as well.
Or you make Marlin create targets.
Or you add -Wl,--as-needed
But make sure that doesn't drop libraries that we need for the EDM at runtime, but not at linktime?
There was a problem hiding this comment.
Yeah forget about this PR for now, I should just close it and have to find how to solve my issues in a different way I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
For example Marlin builds a library called MarlinXML that libraries here don't need to link to