Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the file names of the output files of some tests to avoid clashes #126

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Jul 20, 2023

BEGINRELEASENOTES

  • Change the file names of the output files of some tests to avoid clashes. Fixes running tests in parallel

ENDRELEASENOTES

and possibly failures in the CI tests that I was not able to reproduce locally.

For the changes in the expected output, alternatively, we could grep in the diff to avoid the file names so that they work for any file name; anyway if the content is different it's going to fail regardless of the file name

@jmcarcell jmcarcell merged commit fd39241 into master Jul 20, 2023
1 check failed
@jmcarcell jmcarcell deleted the file-names branch July 20, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants