Remove workarounds for catching non-zero exit codes

key4hep · Sep 13, 2023 · ed1f5d0 · ed1f5d0
1 parent 3c865e1
commit ed1f5d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/doc/starterkit/k4MarlinWrapperCLIC/CEDViaWrapper.md b/doc/starterkit/k4MarlinWrapperCLIC/CEDViaWrapper.md
@@ -124,13 +124,9 @@ With all these pieces put together (as in `examples/event_display.py`) it is now
 ```bash
 glced &
 
-k4run $K4MARLINWRAPPER/examples/event_display.py --EventDataSvc.input=gamma_10GeV_edm4hep.root || true
+k4run $K4MARLINWRAPPER/examples/event_display.py --EventDataSvc.input=gamma_10GeV_edm4hep.root
 ```
 
-Note that we silence the exit code of `k4run` to work around a [framework
-issue](https://github.com/key4hep/k4FWCore/issues/125). This is usually not
-necessary if you run things interactively.
-
 ## Creating a Gaudi options file
 
 The `event_display.py` options file that is used above and that is present in the examples has been produced following these steps:

diff --git a/doc/starterkit/k4MarlinWrapperCLIC/Readme.md b/doc/starterkit/k4MarlinWrapperCLIC/Readme.md
@@ -143,18 +143,12 @@ included with k4MarlinWrapper. Note that:
   + Change the line where `evtsvc.input` is defined to point to the location of your input file.
   + At the bottom of the file, in the `ApplicationMgr` parameters, change `EvtMax   = 3,` to the number of events to run.
 
-This can be run in the following way. Note that we show the usage here in a way
-that also works in scripts with `-e` enabled. This is necessary because of a
-[framework issue](https://github.com/key4hep/k4FWCore/issues/125) that makes
-`k4run` exit with a non-zero exit code even though nothing went wrong.
-
+This can be run in the following way.
 ```bash
 cd CLICPerformance/clicConfig
 
 cp $K4MARLINWRAPPER/examples/clicRec_e4h_input.py .
 
 k4run clicRec_e4h_input.py --EventDataSvc.input ttbar_edm4hep.root
-result=$?
-[ $result = "0" ] || [ $result = "4" ] && true
 ```