Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::unique_ptr<podio::CollectionBase> to save collections in the store and fix leak in the Writer #250

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Use std::unique_ptr<podio::CollectionBase> to save collections in the store and fix leak in the Writer #250

merged 8 commits into from
Oct 28, 2024

Commits on Oct 28, 2024

  1. Use std::unique_ptr<podio::CollectionBase> to save collections in the… 

    … store

Also fix a leak in the Writer that without this change would have
been difficult to fix.
    @jmcarcell
    jmcarcell committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    91eb0fa View commit details
    Browse the repository at this point in the history

  2. Fix a few more leaks

    @jmcarcell
    jmcarcell committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0465b6e View commit details
    Browse the repository at this point in the history

  3. Fix pre-commit

    @jmcarcell
    jmcarcell committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ce3cb35 View commit details
    Browse the repository at this point in the history

  4. Fix pre-commit

    @jmcarcell
    jmcarcell committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    fcb4772 View commit details
    Browse the repository at this point in the history

  5. Fix remaining issues

    @jmcarcell
    jmcarcell committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6389a50 View commit details
    Browse the repository at this point in the history

  6. Fix the last issue

    @jmcarcell
    jmcarcell committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    94279a5 View commit details
    Browse the repository at this point in the history

  7. Improve include ordering and add some comments about usage

    @jmcarcell
    jmcarcell committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    517b081 View commit details
    Browse the repository at this point in the history

  8. Fix pre-commit

    @jmcarcell
    jmcarcell committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    e2d5d3b View commit details
    Browse the repository at this point in the history