Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the object wrapped by a DataWrapper when the DataWrapper is destructed #190

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Delete the object wrapped by a DataWrapper when the DataWrapper is destructed #190

merged 2 commits into from
Apr 18, 2024

Conversation

kjvbrt
Copy link
Contributor

@kjvbrt kjvbrt commented Apr 16, 2024 •
edited by jmcarcell
Loading

BEGINRELEASENOTES

  • Delete the object wrapped by a DataWrapper when the DataWrapper is destructed

ENDRELEASENOTES

Currenty DataWrapper deletes nullptr:

EventDataSvc         INFO Clearing Podio DataWrappers...
EventDataSvc         INFO Podio DataWrappers cleared. 
EventDataSvc         INFO Clearing the Store...                                                            
DataWrapper: Deleting N6HepMC312GenEventDataE?
DataWrapper: is_owner: 1  
DataWrapper: m_data: 0xbaf5870
DataWrapper: No                                                                                            
DataWrapper: Deleting N7edm4hep20MCParticleCollectionE?
DataWrapper: is_owner: 1                                                                                   
DataWrapper: m_data: 0                               
DataWrapper: Yes

@jmcarcell
Copy link
Contributor

I'm having a déjà vu, I'm pretty sure someone else or me said something about this but I can't seem to find anything... I'll edit a bit the title since if you use PodioInput and PodioOutput then everything gets wrapped in these DataWrappers so it does apply to podio based objects.

@jmcarcell jmcarcell changed the title Properly clearing non Podio based objects Delete the object wrapped by a DataWrapper when the DataWrapper is destructed Apr 18, 2024
@jmcarcell jmcarcell merged commit d59cdfe into key4hep:main Apr 18, 2024
7 of 9 checks passed
jmcarcell pushed a commit that referenced this pull request Apr 19, 2024
@kjvbrt @jmcarcell
Delete the object wrapped by a DataWrapper when the DataWrapper is de…
20d9385 
…structed (#190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-fila m-fila m-fila left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjvbrt @jmcarcell @m-fila