Use setMomentum for particles #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What has changed is this: AIDASoft/podio#553 (which is not part of podio v00-99) edit: I am in any case all for the solution that is implemented here as the canonical approach for this. |
|
But that PR was merged on Feb 15 and the nightly build on Feb 16 is using master in podio and main in k4FWCore |
tmadlener
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
I'm not sure what has changed since I think that has been there for a time but
the reference from
getMomentumshould be const. Locally I don't need this fixwith clang 17 and I can't reproduce the error when building on top of the latest
nightlies (that are picking up EDM4hep from a few days ago) but on spack I can
reproduce consistently