Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all python sources using black and add it to pre-commit #177

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Format all python sources using black and add it to pre-commit

ENDRELEASENOTES

@tmadlener
Copy link
Contributor Author

I can squash the non-formatting changes into one commit so that the format one can be more easily be put into the ignore-revs file

@tmadlener
Copy link
Contributor Author

Anyone with any objections for this?

@jmcarcell
Copy link
Contributor

I prefer ' instead of " 😢

The choice should be the same for all the Key4hep repos with a single configuration file distributed everywhere. I guess it makes sense it's the black format since it's convenient to use it in key4hep-spack. So I don't have anything against this, once we agree I can do the formatting on all repos (not always easy depending on the number of open PRs...)

@tmadlener
Copy link
Contributor Author

I prefer ' instead of " 😢

Not much we can do there without post-black hooks, I am afraid. I would just stay with whatever it does.

For the other repos I would gradually go through. I also think this should be a bit less painful than e.g. c++ and clang-format, because there is not too much python code.

@tmadlener tmadlener merged commit 6f1c573 into key4hep:main Feb 28, 2024
4 of 9 checks passed
@tmadlener tmadlener deleted the fmt-black branch February 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants