Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k4run: fix more bugs #140

Merged
merged 3 commits into from
Sep 1, 2023
Merged

k4run: fix more bugs #140

merged 3 commits into from
Sep 1, 2023

Conversation

Zehvogel
Copy link
Contributor

@Zehvogel Zehvogel commented Aug 29, 2023

BEGINRELEASENOTES

  • k4run: give exec its own dict for globals and locals to make list comprehensions usable in option files again
  • k4run: make configurables a frozenset to avoid duplicates

ENDRELEASENOTES

see also #141

@Zehvogel Zehvogel changed the title k4run: give exec its own dict for globals and locals k4run: fix more bugs Aug 29, 2023
@andresailer
Copy link
Contributor

Please install pre-commit, and then pre-commit install in your working directory.

@Zehvogel
Copy link
Contributor Author

fixes #141
see: #141 (comment)

@jmcarcell
Copy link
Contributor

By the way:

In [7]: %timeit frozenset(ApplicationMgr().allConfigurables.values())
3.78 µs ± 9.98 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

In [8]: %timeit set(ApplicationMgr().allConfigurables.values())
3.86 µs ± 8.5 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

In [9]: %timeit set(ApplicationMgr().allConfigurables.values())
3.77 µs ± 12.3 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

so it's the same

@jmcarcell jmcarcell enabled auto-merge (squash) September 1, 2023 07:51
@jmcarcell jmcarcell merged commit 4a0b6a8 into key4hep:main Sep 1, 2023
2 of 5 checks passed
@Zehvogel Zehvogel deleted the exec branch September 1, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants