Make MCParticle momenta use doubles instead of floats #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* Make momentum use doubles instead of floats * Fix python unittests * Add a constructor from Vector3f for Vector3d This direction should not suffer from narrowing
jmcarcell
force-pushed
the
double-momentum
branch
from
3d7a7f5
to
6f8e858
Compare
|
This was auto-merged but not all the CI passed, there seems to be something broken in the wrapper that I think we already knew about: |
|
I think this is based on alma9 and things should work there. The break in the wrapper is only present for centos7 on the nightlies. |
|
That CI is running on Alma 9, so I think there is something wrong that doesn't always happen |
|
This might actually just be because the file that is read in some tests can no longer be read due to all the changes. We will have to check that and create a new one once we are done. |
This was referenced Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES