[Vertical layout] Remove data-bs-theme from header

[cavasinf]

Description

This fixes code/logic that is not in Tabler today.
See <header> at https://preview.tabler.io/layout-combo.html

It ends up as a bug when you want to redefine the primary color:

As it is today:

---

How it should be (as Tabler demo):

Works as expected in mobile view:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I updated the documentation (see here)
• I agree that this code will be published under the MIT license

[cavasinf]

Is this considered as a BC break? 🤔

[kevinpapst]

My app uses default colors and dark/light switch.
Removing the attribute doesn't change anything here.
And if it fixes a bug, I doubt that this is a BC break.

Did you check horizontal?
The tabler demo doesn't have it there as well, but our horizontal theme still has it:
https://github.com/kevinpapst/TablerBundle/blob/main/templates/layout-horizontal.html.twig#L30

[cavasinf]

Did you check horizontal? The tabler demo doesn't have it there as well, but our horizontal theme still has it: https://github.com/kevinpapst/TablerBundle/blob/main/templates/layout-horizontal.html.twig#L30

Yeah, and Overlap mode needs that: https://preview.tabler.io/layout-navbar-overlap.html

[kevinpapst]

and Overlap mode needs that

Oh wow, how annoying 😁

Do you need a new minor release?

[kevinpapst]

Thanks @cavasinf 👍