Version 1.0

[kevinpapst]

Description

• Symfony 6 only
• PHP 8 only
• Phpstan level 9
• Fixes deprecation with SF 6.3 about missing return types

Besides the obvious BC breaks due to added return types, there is one BC break that needs attention.

The UserInterface whose method changed from getIdentifier() to getUserIdentifier().
As latter method is part of the Symfony User Interface, this shouldn't be an issue, as we target SF 6 only.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I updated the documentation (see here)
• I agree that this code will be published under the MIT license

[tacman]

This is great! Can you also add Symfony 7, which will be out in 2 months?

My branch of the demo works with Symfony 6.4 and I've been removing deprecation warnings.

[cavasinf]

I'm OK with the job except for class property inside constructors.

I don't think we should pre-shot Symfony 7 though.

[cavasinf]

I'm not a big fan of putting class members INSIDE the constructor.

1. When using PHP Attributes inside constructor parameters it can be messy.
2. We have encountered a lot of confusing behavior logic when using it that way (in our company).
3. Even more in a single line! It will be a pain when resolving conflicts on merge! (trust me 😭)

No complaint when using autowire though, just on models like this one.

I'll go:

public function __construct(
    private string $id, 
    private string $message, 
    private string $type = Constants::TYPE_INFO
) {
}

Or back to OLD way

private string $id;
private string $message; 
private string $type;
private ?string $url = null;

public function __construct(
    string $id, 
    string $message, 
    string $type = Constants::TYPE_INFO,
) {
    $this->id = $id;
    $this->message = $message;
    $this->type = $type;
}

[cavasinf]

If you are using rector to do this PR, we have added the Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector to the skip config. And do this upgrade only where needed.

[cavasinf]

Same here

[cavasinf]

What about those issues @kevinpapst?

[kevinpapst]

My changes are BC breaks, that's why we need to bump to 1.0.
Also I am not a big fan of the "I am waiting for years until 1.0" release tactic.
It is time to signal that the bundle is stable.
And there is always a time for new major release if we do BC breaks in the future (e.g. remove |trans filter).

Lets move the tickets to a new milestone and close the linked one.
SF 6.3 is out and there are deprecations that need to be fixed now.
SF7 is coming soon, we should be prepared.

I agree, we can always release a 1.1 to support SF7 in two month.

Regarding your code comments: these files were NEVER changed since I committed them 2 years ago.
I am working mostly by myself since years, so you have better insights in merge problems. Larger teams on active codebases obviously have different needs than projects like this one 😄
But I do not see a big risk here, due to the rare commits in the last months 🤷 which is actually a good sign of stability IMO.