Use tempfile crate to make tempfiles #8

n8henrie · 2019-01-02T17:44:47Z

Fixes #7

Removes dependency on nix Adds dependency on tempfile Fixes build failure on MacOS due to absence of `O_TMPFILE` Fixes kevincox#7

CLAassistant · 2019-01-02T17:44:54Z

All committers have signed the CLA.

kevincox · 2019-01-03T15:05:30Z

src/ffmpeg.rs

-		{ use nix::sys::stat::*; S_IRUSR | S_IWUSR })?;
-	let file = unsafe { std::fs::File::from_raw_fd(fd) };
-
+	let file = tempfile::tempfile().expect("Error opening tempfile");


The error should be returned like it was previously instead of panicking.

Cargo.toml

Use tempfile crate to create tempfile

fb97516

Removes dependency on nix Adds dependency on tempfile Fixes build failure on MacOS due to absence of `O_TMPFILE` Fixes kevincox#7

kevincox approved these changes Jan 3, 2019

View reviewed changes

Remove caret from tempfile dependency

a1317ed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use tempfile crate to make tempfiles #8

Use tempfile crate to make tempfiles #8

n8henrie commented Jan 2, 2019

CLAassistant commented Jan 2, 2019 •

edited

Loading

kevincox Jan 3, 2019

Use tempfile crate to make tempfiles #8

Are you sure you want to change the base?

Use tempfile crate to make tempfiles #8

Conversation

n8henrie commented Jan 2, 2019

CLAassistant commented Jan 2, 2019 • edited Loading

kevincox Jan 3, 2019

Choose a reason for hiding this comment

CLAassistant commented Jan 2, 2019 •

edited

Loading