Drop support for Lua 5.2

I realized late that Lua 5.2 doesn't support bitwise operators... I don't think it's worth my time to be backwards compatible there, so just drop it entirely. Signed-off-by: Kyle Evans <[email protected]>
kevans91 · Jan 25, 2024 · f7736a1 · f7736a1
1 parent 2abfdf3
commit f7736a1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -15,7 +15,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04, ubuntu-22.04, macos-latest]
-        lua: [5.2, 5.3, 5.4]
+        lua: [5.3, 5.4]
         include:
           - os: ubuntu-20.04
           - os: ubuntu-22.04
@@ -25,8 +25,6 @@ jobs:
         exclude:
           - os: ubuntu-20.04
             lua: 5.4
-          - os: macos-latest
-            lua: 5.2
           - os: macos-latest
             lua: 5.3
     steps:

diff --git a/lib/orch.lua b/lib/orch.lua
@@ -399,7 +399,7 @@ end
 
 local function include_file(file, alter_path, env)
 	local f = assert(impl.open(file, alter_path))
-	local chunk = f:read("*l")	-- * for compatibility with Lua 5.2...
+	local chunk = f:read("l")
 
 	if not chunk then
 		error(file .. " appears to be empty!")
@@ -412,7 +412,7 @@ local function include_file(file, alter_path, env)
 		chunk = chunk .. "\n"
 	end
 
-	chunk = chunk .. assert(f:read("*a"))
+	chunk = chunk .. assert(f:read("a"))
 	local func = assert(load(chunk, "@" .. file, "t", env))
 
 	return execute(func, true)

diff --git a/lib/orch_lib.h b/lib/orch_lib.h
@@ -14,7 +14,7 @@
 #include <lua.h>
 #include <lauxlib.h>
 
-/* We only support Lua 5.2+ */
+/* We only support Lua 5.3+ */
 
 /* Introduced in Lua 5.4 */
 #ifndef luaL_pushfail