Skip to content

Commit

Permalink
[CELEBORN-448][FOLLOWUP] HeartbeatFromApplicationResponse should incl…
Browse files Browse the repository at this point in the history
…ude manually excluded workers

### What changes were proposed in this pull request?

Fix `HeartbeatFromApplicationResponse` does not include manually excluded workers.

### Why are the changes needed?

`HeartbeatFromApplicationResponse` should include manually excluded workers, otherwise `WorkerStatusTracker` misses the manually excluded workers.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Local test and GA.

Closes apache#2297 from SteNicholas/CELEBORN-448.

Authored-by: SteNicholas <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
  • Loading branch information
SteNicholas committed Feb 18, 2024
1 parent e4f7ea8 commit 67d8236
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,8 @@ private[celeborn] class Master(
if (shouldResponse) {
context.reply(HeartbeatFromApplicationResponse(
StatusCode.SUCCESS,
new util.ArrayList(statusSystem.excludedWorkers),
new util.ArrayList(
(statusSystem.excludedWorkers.asScala ++ statusSystem.manuallyExcludedWorkers.asScala).asJava),
needCheckedWorkerList,
shutdownWorkerSnapshot))
} else {
Expand Down

0 comments on commit 67d8236

Please sign in to comment.