Skip to content

Commit

Permalink
[CELEBORN-1026] Optimize registerShuffle fallback log
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

### Why are the changes needed?
According to apache#1955 , when celeborn is not available, `spark.dynamicAllocation.enabled=true` and  `spark.shuffle.service. enabled=true`, shuffle data should not be lost.

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Closes apache#1963 from cxzl25/CELEBORN-1026.

Authored-by: sychen <[email protected]>
Signed-off-by: Shuang <[email protected]>
  • Loading branch information
cxzl25 authored and RexXiong committed Oct 11, 2023
1 parent 84a318f commit 62ba44d
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ public <K, V, C> ShuffleHandle registerShuffle(

if (fallbackPolicyRunner.applyAllFallbackPolicy(
lifecycleManager, dependency.partitioner().numPartitions())) {
if (conf.getBoolean("spark.dynamicAllocation.enabled", false)) {
if (conf.getBoolean("spark.dynamicAllocation.enabled", false)
&& !conf.getBoolean("spark.shuffle.service.enabled", false)) {
logger.error(
"DRA is enabled but we fallback to vanilla Spark SortShuffleManager for "
+ "shuffle: {} due to fallback policy. It may cause block can not found when reducer "
Expand Down

0 comments on commit 62ba44d

Please sign in to comment.