Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Approximating non function mapping example #1440

Merged
merged 12 commits into from
Aug 11, 2023

Conversation

LukeWood
Copy link
Contributor

@LukeWood LukeWood commented Jul 16, 2023

This guide covers how to approximate non-function one to many mappings using Keras Core: https://colab.research.google.com/drive/1kRYIn8lMuvK8wc9uloEwJvZ7foTUNPnV?usp=sharing

PTAL!

python autogen.py add_example keras_recipes/approximating_non_function_mappings
Fix patience.
Fix limits.
Add tfp link.
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put a bunch of fixes in this PR:

LukeWood#2, Please merge, lgtm.

I wasn't able to push it directly to your branch.

Do new files need to be added to index pages for keras.io?

Copy link
Contributor Author

@LukeWood LukeWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet I think this looks pretty good - @MarkDaoust added some edits.

I left a few final copy-edits on my own wording which I can apply later today - but let me know if this is a good addition.

Edit: sorry, misunderstood Mark's comment. Merged his PR on my repo.

@LukeWood
Copy link
Contributor Author

LukeWood commented Aug 8, 2023

@MarkDaoust I merged them - let me know if anything else is needed!

@LukeWood
Copy link
Contributor Author

LukeWood commented Aug 8, 2023

FYI @MarkDaoust you may want to re-generate the markdown, the learned MDN is pretty poor here - and I've been able to get much stronger convergences. Maybe we can just run it 1-2 more times to get good figures

Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MarkDaoust
Copy link
Collaborator

@LukeWood did you want to add those copy edits and regenerate, or should I just merge this?

@LukeWood
Copy link
Contributor Author

LukeWood commented Aug 8, 2023

Go ahead @MarkDaoust - I think the point is still clear and I'm happy with it. Cheers!

@MarkDaoust MarkDaoust merged commit fa65d76 into keras-team:master Aug 11, 2023
3 checks passed
@LukeWood LukeWood deleted the approximatingnonfunctions branch August 12, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants