[Keras-Sprint] Modification of the UNet example #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gorner
suggested changes
Jun 19, 2023
|
Changes look good. Can you also post the latest Colab for review ? The one linked above does not seem to correspond to the PR (for ex. it has the Cosine decay LR still in it but commented out, which i do not see in the commit. Also the Colab uses PiecewiseConstantDecay which i do not see in the commit either.). |
ianstenbit
reviewed
Jun 27, 2023
| """ | ||
| ## What does one input image and corresponding segmentation mask look like? | ||
|
|
||
| key_rename_fn = lambda inputs: { |
There was a problem hiding this comment.
Is this the right name? It seems more like a rescaling / bias term operation
There was a problem hiding this comment.
What would you suggest?
There was a problem hiding this comment.
Maybe rescale_images_and_correct_masks?
|
@fchollet over to you for the final review! |
|
I worked with Aritra on this example. This is the final version. |
martin-gorner
approved these changes
Jul 13, 2023
|
@martin-gorner I have also added the generated files! |
ianstenbit
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an effort to modify the Unet example with KerasCV.
Colab Notebook
CC: https://github.com/martin-gorner, https://github.com/margaretmz