Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add special_tokens_in_strings Arg to byte_pair_tokenizer. #1546

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add special_tokens_in_strings Arg to byte_pair_tokenizer. #1546

wants to merge 4 commits into from

Conversation

abuelnasr0
Copy link
Contributor

@abuelnasr0 abuelnasr0 commented Apr 2, 2024 •
edited
Loading

I opened this PR instead of #1447.
This PR:

  1. Adds special_tokens_in_strings Arg to byte_pair_tokenizer.
  2. solves the bug of tokenizing <s> and </s> to the same id.
  3. moves special tokens checking into the base class.

I also renamed unsplittable_tokens to special_tokens to be similar to other tokenizers. not sure if it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abuelnasr0