forked from flutter/devtools
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor memory screen. (flutter#7518)
- Loading branch information
Showing
36 changed files
with
869 additions
and
700 deletions.
There are no files selected for viewing
File renamed without changes.
16 changes: 16 additions & 0 deletions
16
packages/devtools_app/lib/src/screens/memory/DEPENDENCIES.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <!--- | ||
| Generated by https://github.com/polina-c/layerlens | ||
| Dependencies that create loops (inversions) are marked with `!`. | ||
| --> | ||
|
|
||
| ```mermaid | ||
| flowchart TD; | ||
| framework-->panes; | ||
| panes-->shared; | ||
| ``` | ||
|
|
||
| ### Inversions | ||
| In this folder: 0 | ||
|
|
||
| Including sub-folders: 0 | ||
|
|
15 changes: 15 additions & 0 deletions
15
packages/devtools_app/lib/src/screens/memory/framework/DEPENDENCIES.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <!--- | ||
| Generated by https://github.com/polina-c/layerlens | ||
| Dependencies that create loops (inversions) are marked with `!`. | ||
| --> | ||
|
|
||
| ```mermaid | ||
| flowchart TD; | ||
| memory_screen.dart-->connected; | ||
| ``` | ||
|
|
||
| ### Inversions | ||
| In this folder: 0 | ||
|
|
||
| Including sub-folders: 0 | ||
|
|
17 changes: 17 additions & 0 deletions
17
packages/devtools_app/lib/src/screens/memory/framework/connected/DEPENDENCIES.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <!--- | ||
| Generated by https://github.com/polina-c/layerlens | ||
| Dependencies that create loops (inversions) are marked with `!`. | ||
| --> | ||
|
|
||
| ```mermaid | ||
| flowchart TD; | ||
| connected_screen_body.dart-->memory_controller.dart; | ||
| connected_screen_body.dart-->memory_tabs.dart; | ||
| memory_tabs.dart-->memory_controller.dart; | ||
| ``` | ||
|
|
||
| ### Inversions | ||
| In this folder: 0 | ||
|
|
||
| Including sub-folders: 0 | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
packages/devtools_app/lib/src/screens/memory/panes/chart/DEPENDENCIES.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <!--- | ||
| Generated by https://github.com/polina-c/layerlens | ||
| Dependencies that create loops (inversions) are marked with `!`. | ||
| --> | ||
|
|
||
| ```mermaid | ||
| flowchart TD; | ||
| controller-->data; | ||
| widgets-->controller; | ||
| widgets-->data; | ||
| ``` | ||
|
|
||
| ### Inversions | ||
| In this folder: 0 | ||
|
|
||
| Including sub-folders: 0 | ||
|
|
18 changes: 18 additions & 0 deletions
18
...ages/devtools_app/lib/src/screens/memory/panes/chart/controller/DEPENDENCIES.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <!--- | ||
| Generated by https://github.com/polina-c/layerlens | ||
| Dependencies that create loops (inversions) are marked with `!`. | ||
| --> | ||
|
|
||
| ```mermaid | ||
| flowchart TD; | ||
| chart_pane_controller.dart-->android_chart_controller.dart; | ||
| chart_pane_controller.dart-->event_chart_controller.dart; | ||
| chart_pane_controller.dart-->memory_tracker.dart; | ||
| chart_pane_controller.dart-->vm_chart_controller.dart; | ||
| ``` | ||
|
|
||
| ### Inversions | ||
| In this folder: 0 | ||
|
|
||
| Including sub-folders: 0 | ||
|
|
110 changes: 110 additions & 0 deletions
110
.../devtools_app/lib/src/screens/memory/panes/chart/controller/android_chart_controller.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| // Copyright 2024 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import 'package:devtools_shared/devtools_shared.dart'; | ||
| import 'package:flutter/foundation.dart'; | ||
|
|
||
| import '../../../../../shared/charts/chart_controller.dart'; | ||
| import '../../../../../shared/charts/chart_trace.dart' as chart_trace; | ||
| import '../../../shared/primitives/memory_timeline.dart'; | ||
| import '../data/charts.dart'; | ||
|
|
||
| class AndroidChartController extends ChartController { | ||
| AndroidChartController( | ||
| this.memoryTimeline, { | ||
| required this.paused, | ||
| List<int> sharedLabels = const <int>[], | ||
| }) : super( | ||
| name: 'Android', | ||
| sharedLabelTimestamps: sharedLabels, | ||
| ); | ||
|
|
||
| final ValueListenable<bool> paused; | ||
| final MemoryTimeline memoryTimeline; | ||
|
|
||
| // TODO(terry): Only load max visible data collected, when pruning of data | ||
| // charted is added. | ||
| /// Preload any existing data collected but not in the chart. | ||
| @override | ||
| void setupData() { | ||
| // Only display if traces have been created. Android memory may not | ||
| // have been toggled to be displayed - yet. | ||
| if (traces.isNotEmpty) { | ||
| final chartDataLength = timestampsLength; | ||
| final dataLength = memoryTimeline.data.length; | ||
|
|
||
| final dataRange = memoryTimeline.data.getRange( | ||
| chartDataLength, | ||
| dataLength, | ||
| ); | ||
|
|
||
| dataRange.forEach(addSample); | ||
| } | ||
| } | ||
|
|
||
| /// Loads all heap samples (live data or offline). | ||
| void addSample(HeapSample sample) { | ||
| // If paused don't update the chart (data is still collected). | ||
| if (paused.value) return; | ||
|
|
||
| addTimestamp(sample.timestamp); | ||
|
|
||
| final timestamp = sample.timestamp; | ||
| final adb = sample.adbMemoryInfo; | ||
|
|
||
| final stackValue = adb.stack.toDouble(); | ||
| addDataToTrace( | ||
| AndroidTraceName.stack.index, | ||
| chart_trace.Data(timestamp, stackValue), | ||
| ); | ||
|
|
||
| final graphicValue = adb.graphics.toDouble(); | ||
| addDataToTrace( | ||
| AndroidTraceName.graphics.index, | ||
| chart_trace.Data( | ||
| timestamp, | ||
| graphicValue, | ||
| ), | ||
| ); | ||
|
|
||
| final nativeHeapValue = adb.nativeHeap.toDouble(); | ||
| addDataToTrace( | ||
| AndroidTraceName.nativeHeap.index, | ||
| chart_trace.Data( | ||
| timestamp, | ||
| nativeHeapValue, | ||
| ), | ||
| ); | ||
|
|
||
| final javaHeapValue = adb.javaHeap.toDouble(); | ||
| addDataToTrace( | ||
| AndroidTraceName.javaHeap.index, | ||
| chart_trace.Data(timestamp, javaHeapValue), | ||
| ); | ||
|
|
||
| final codeValue = adb.code.toDouble(); | ||
| addDataToTrace( | ||
| AndroidTraceName.code.index, | ||
| chart_trace.Data(timestamp, codeValue), | ||
| ); | ||
|
|
||
| final otherValue = adb.other.toDouble(); | ||
| addDataToTrace( | ||
| AndroidTraceName.other.index, | ||
| chart_trace.Data(timestamp, otherValue), | ||
| ); | ||
|
|
||
| final systemValue = adb.system.toDouble(); | ||
| addDataToTrace( | ||
| AndroidTraceName.system.index, | ||
| chart_trace.Data(timestamp, systemValue), | ||
| ); | ||
|
|
||
| final totalValue = adb.total.toDouble(); | ||
| addDataToTrace( | ||
| AndroidTraceName.total.index, | ||
| chart_trace.Data(timestamp, totalValue), | ||
| ); | ||
| } | ||
| } |
Oops, something went wrong.