forked from flutter/devtools
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Primary purpose of this PR is to implement export for snapshots. For release notes: <img width="233" alt="Screenshot 2024-03-07 at 11 01 08�AM" src="https://github.com/flutter/devtools/assets/12115586/6889070b-febf-48f3-8456-cf9081b0d1bc"> Side effects of this PR are: 1. Refactored structure of snapshot diffing, because we want to store the snapshot in original format 2. Improved performance of snapshotting (increased number of snapshots that can be taken 10 times and performance 2 times). Also this PR suggests to un-ignore DEPENDENCIES.md for folders where they help to understand code. Performance for DevTools in release mode, in chrome, connected to and on mac in debug mode, home page, on polina-c's mac: 1. Gallery, taking snapshots sequentially, one after another: - Original: 3 snapshots takes 30 sec, crash happens on 6th snapshot - New, before upgrade of vm_service: three snapshots 15 sec, OOM crash on 60th snapshot 2. DevTools, with every screen opened, memory chart collapsed (per activity monitor takes almost 3 GB): - Original: crash on first snapshot - New: first snapshot takes ~10 min, crash on second one TODO for this PR:
- Loading branch information
Showing
79 changed files
with
2,366 additions
and
1,714 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
packages/devtools_app/lib/src/screens/memory/panes/diff/.gitignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
!DEPENDENCIES.md |
19 changes: 19 additions & 0 deletions
19
packages/devtools_app/lib/src/screens/memory/panes/diff/DEPENDENCIES.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<!--- | ||
Generated by https://github.com/polina-c/layerlens | ||
Dependencies that create loops (inversions) are marked with `!`. | ||
--> | ||
|
||
```mermaid | ||
flowchart TD; | ||
controller-->data; | ||
diff_pane.dart-->controller; | ||
diff_pane.dart-->widgets; | ||
widgets-->controller; | ||
widgets-->data; | ||
``` | ||
|
||
### Inversions | ||
In this folder: 0 | ||
|
||
Including sub-folders: 0 | ||
|
16 changes: 16 additions & 0 deletions
16
packages/devtools_app/lib/src/screens/memory/panes/diff/controller/DEPENDENCIES.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<!--- | ||
Generated by https://github.com/polina-c/layerlens | ||
Dependencies that create loops (inversions) are marked with `!`. | ||
--> | ||
|
||
```mermaid | ||
flowchart TD; | ||
diff_pane_controller.dart-->class_data.dart; | ||
diff_pane_controller.dart-->item_controller.dart; | ||
``` | ||
|
||
### Inversions | ||
In this folder: 0 | ||
|
||
Including sub-folders: 0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.