Move code out of connected. (flutter#7534)

Move code, that handles all screen modes, out of `connected`.

packages/devtools_app/lib/devtools_app.dart

@@ -26,7 +26,7 @@ export 'src/screens/inspector/inspector_screen.dart';
 export 'src/screens/inspector/inspector_tree_controller.dart';
 export 'src/screens/logging/logging_controller.dart';
 export 'src/screens/logging/logging_screen.dart';
-export 'src/screens/memory/framework/connected/memory_controller.dart';
+export 'src/screens/memory/framework/memory_controller.dart';
 export 'src/screens/memory/framework/memory_screen.dart';
 export 'src/screens/network/network_controller.dart';
 export 'src/screens/network/network_model.dart';

packages/devtools_app/lib/src/app.dart

@@ -29,7 +29,7 @@ import 'screens/inspector/inspector_screen.dart';
 import 'screens/inspector/inspector_tree_controller.dart';
 import 'screens/logging/logging_controller.dart';
 import 'screens/logging/logging_screen.dart';
-import 'screens/memory/framework/connected/memory_controller.dart';
+import 'screens/memory/framework/memory_controller.dart';
 import 'screens/memory/framework/memory_screen.dart';
 import 'screens/network/network_controller.dart';
 import 'screens/network/network_screen.dart';

packages/devtools_app/lib/src/screens/memory/framework/DEPENDENCIES.md

@@ -5,7 +5,10 @@ Dependencies that create loops (inversions) are marked with `!`.
 
 ```mermaid
 flowchart TD;
-memory_screen.dart-->connected;
+memory_screen.dart-->screen_body.dart;
+memory_tabs.dart-->memory_controller.dart;
+screen_body.dart-->memory_controller.dart;
+screen_body.dart-->memory_tabs.dart;
 ```
 
 ### Inversions

packages/devtools_app/lib/src/screens/memory/framework/connected/memory_controller.dart → packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart

@@ -5,13 +5,13 @@
 import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/foundation.dart';
 
-import '../../../../shared/memory/class_name.dart';
-import '../../../../shared/memory/heap_graph_loader.dart';
-import '../../panes/chart/controller/chart_pane_controller.dart';
-import '../../panes/control/controller/control_pane_controller.dart';
-import '../../panes/diff/controller/diff_pane_controller.dart';
-import '../../panes/profile/profile_pane_controller.dart';
-import '../../panes/tracing/tracing_pane_controller.dart';
+import '../../../shared/memory/class_name.dart';
+import '../../../shared/memory/heap_graph_loader.dart';
+import '../panes/chart/controller/chart_pane_controller.dart';
+import '../panes/control/controller/control_pane_controller.dart';
+import '../panes/diff/controller/diff_pane_controller.dart';
+import '../panes/profile/profile_pane_controller.dart';
+import '../panes/tracing/tracing_pane_controller.dart';
 
 /// This class contains the business logic for memory screen, for a connected
 /// application.

packages/devtools_app/lib/src/screens/memory/framework/memory_screen.dart

@@ -8,7 +8,7 @@ import 'package:flutter/material.dart';
 import '../../../shared/analytics/analytics.dart' as ga;
 import '../../../shared/primitives/listenable.dart';
 import '../../../shared/screen.dart';
-import 'connected/connected_screen_body.dart';
+import 'screen_body.dart';
 
 class MemoryScreen extends Screen {
   MemoryScreen() : super.fromMetaData(ScreenMetaData.memory);

packages/devtools_app/lib/src/screens/memory/framework/connected/memory_tabs.dart → packages/devtools_app/lib/src/screens/memory/framework/memory_tabs.dart

@@ -4,12 +4,12 @@
 
 import 'package:flutter/material.dart';
 
-import '../../../../shared/analytics/constants.dart' as gac;
-import '../../../../shared/common_widgets.dart';
-import '../../../../shared/ui/tab.dart';
-import '../../panes/diff/diff_pane.dart';
-import '../../panes/profile/profile_view.dart';
-import '../../panes/tracing/tracing_view.dart';
+import '../../../shared/analytics/constants.dart' as gac;
+import '../../../shared/common_widgets.dart';
+import '../../../shared/ui/tab.dart';
+import '../panes/diff/diff_pane.dart';
+import '../panes/profile/profile_view.dart';
+import '../panes/tracing/tracing_view.dart';
 import 'memory_controller.dart';
 
 @visibleForTesting

packages/devtools_app/lib/src/screens/memory/framework/connected/connected_screen_body.dart → packages/devtools_app/lib/src/screens/memory/framework/screen_body.dart

@@ -6,12 +6,12 @@ import 'package:devtools_app_shared/ui.dart';
 import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/material.dart';
 
-import '../../../../shared/banner_messages.dart';
-import '../../../../shared/http/http_service.dart' as http_service;
-import '../../../../shared/screen.dart';
-import '../../../../shared/utils.dart';
-import '../../panes/chart/widgets/chart_pane.dart';
-import '../../panes/control/widgets/control_pane.dart';
+import '../../../shared/banner_messages.dart';
+import '../../../shared/http/http_service.dart' as http_service;
+import '../../../shared/screen.dart';
+import '../../../shared/utils.dart';
+import '../panes/chart/widgets/chart_pane.dart';
+import '../panes/control/widgets/control_pane.dart';
 import 'memory_controller.dart';
 import 'memory_tabs.dart';
 

packages/devtools_app/test/memory/diff/widgets/diff_pane_test.dart

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 import 'package:devtools_app/devtools_app.dart';
-import 'package:devtools_app/src/screens/memory/framework/connected/memory_tabs.dart';
+import 'package:devtools_app/src/screens/memory/framework/memory_tabs.dart';
 import 'package:devtools_app/src/screens/memory/panes/diff/diff_pane.dart';
 import 'package:devtools_app/src/screens/memory/panes/diff/widgets/snapshot_list.dart';
 import 'package:devtools_test/helpers.dart';

packages/devtools_app/test/memory/framework/memory_controller_test.dart

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 import 'package:devtools_app/devtools_app.dart';
-import 'package:devtools_app/src/screens/memory/framework/connected/memory_tabs.dart';
+import 'package:devtools_app/src/screens/memory/framework/memory_tabs.dart';
 import 'package:devtools_app/src/screens/memory/shared/heap/class_filter.dart';
 import 'package:devtools_test/helpers.dart';
 import 'package:flutter/material.dart';

packages/devtools_app/test/memory/framework/memory_service_test.dart

@@ -5,7 +5,7 @@
 @TestOn('vm')
 import 'dart:async';
 
-import 'package:devtools_app/src/screens/memory/framework/connected/memory_controller.dart';
+import 'package:devtools_app/src/screens/memory/framework/memory_controller.dart';
 import 'package:devtools_app/src/screens/memory/panes/chart/controller/memory_tracker.dart';
 import 'package:devtools_app/src/screens/memory/shared/primitives/memory_timeline.dart';
 import 'package:devtools_app/src/shared/globals.dart';

packages/devtools_app/test/memory/profile/allocation_profile_table_view_test.dart

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import 'package:devtools_app/src/screens/memory/framework/connected/memory_tabs.dart';
 import 'package:devtools_app/src/screens/memory/framework/memory_screen.dart';
+import 'package:devtools_app/src/screens/memory/framework/memory_tabs.dart';
 import 'package:devtools_app/src/screens/memory/panes/profile/model.dart';
 import 'package:devtools_app/src/screens/memory/panes/profile/profile_pane_controller.dart';
 import 'package:devtools_app/src/screens/vm_developer/vm_service_private_extensions.dart';

packages/devtools_app/test/memory/tracing/tracing_view_test.dart

@@ -6,7 +6,7 @@ import 'dart:convert';
 import 'dart:io';
 
 import 'package:devtools_app/devtools_app.dart';
-import 'package:devtools_app/src/screens/memory/framework/connected/memory_tabs.dart';
+import 'package:devtools_app/src/screens/memory/framework/memory_tabs.dart';
 import 'package:devtools_app/src/screens/memory/panes/tracing/tracing_pane_controller.dart';
 import 'package:devtools_app/src/screens/memory/panes/tracing/tracing_tree.dart';
 import 'package:devtools_app_shared/utils.dart';