Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hanmanwuzhe source #5099

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add hanmanwuzhe source #5099

wants to merge 2 commits into from
+251 −0

Conversation

heagan01
Copy link
Contributor

Closes #5086

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

anenasa
anenasa reviewed Sep 18, 2024
View reviewed changes
src/zh/hanmanwuzhe/src/eu/kanade/tachiyomi/extension/zh/hanmanwuzhe/hanmanwuzhe.kt Outdated
return GET(page.imageUrl!!, newHeaders)
}

private class Genre(name: String, val id: String = name) : Filter.CheckBox(name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, why use CheckBox if only one genre can be chosen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the functions, sorry 😅, is there a function for a radio button?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Filter.Select to create drop-down list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will try

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this alright?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emmm, I would suggest using Pair so you can put genre name and url in the same array. You can read code of other extensions, like manhuaren or zerobyw

@stevenyomi
Copy link
Contributor

This site is MCCMS, I'll review later.

@stevenyomi stevenyomi marked this pull request as draft September 18, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anenasa anenasa anenasa left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add source: 韩漫无遮挡 / hanmanwuzhe
3 participants
@heagan01 @stevenyomi @anenasa