Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert hit when viewing entry history #11413

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

droidmonkey
Copy link
Member

Testing strategy

Added unit test

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added this to the v2.7.10 milestone Oct 26, 2024
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 14 lines in your changes missing coverage. Please review.

Project coverage is 63.87%. Comparing base (5d24495) to head (e30c0de).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/entry/EditEntryWidget.cpp 56.67% 13 Missing ⚠️
src/gui/EditWidget.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11413      +/-   ##
===========================================
+ Coverage    63.78%   63.87%   +0.09%     
===========================================
  Files          362      362              
  Lines        38072    38104      +32     
===========================================
+ Hits         24282    24336      +54     
+ Misses       13790    13768      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@droidmonkey droidmonkey force-pushed the hotfix/history-assert branch 2 times, most recently from 4d07b6f to 64479a1 Compare October 26, 2024 21:18
* Fixes #11371
* Adds test for showing entry history
* Improved page switching capabilities for entry edit widget
Copy link
Member

@varjolintu varjolintu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Tried it also with disabling certain features to make sure the indexing doesn't get broken etc.

@droidmonkey droidmonkey merged commit 2738a72 into develop Oct 27, 2024
11 checks passed
@droidmonkey droidmonkey deleted the hotfix/history-assert branch October 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KepePassXC Snapshot crashes when trying to show a history element of an entry
2 participants