Clean up wordlist by removing hyphenated words and trailing newline #11409
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newline at the end of the file was removed, as well as 4 words that contain a hyphen: drop-in felt-tip t-shirt yo-yo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newline at the end of the eff_large.wordlist file was removed, as well as the 4 words that contain a hyphen:
drop-in
felt-tip
t-shirt
yo-yo
This change is useful, because when generating a passphrase you generally will not be able to use (or want to use) hyphens. The newline at the end of the file is removed to prevent breakages for anyone trying to export and use this list for their own projects. Note that the newline may replace itself depending on how GitHub handles it.
Type of change