-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passphrase "MIXED case" Type #11255
base: develop
Are you sure you want to change the base?
Passphrase "MIXED case" Type #11255
Conversation
Do not add the actual translations to a PR, just the English build from running the qt linguist tool. However, this PR is unlikely to be merged as it defeats the purpose of a passphrase. The whole point is to be able to remember the passphrase. If that isn't your point, use a random password. Adding more randomness to a passphrase all but guarantees you'll forget it. |
The intention is to create a passphrase variant, that can be remembered but can also fulfil additional requirements like numbers and symbols and uppercase letters. It's for sure not a passphrase by definition, but still useful and usable. Due to the open separator character selection, it can be used quite flexible. |
I actually didn't know you could add multiple characters to the separator field, lol |
I'll merge this after thinking it through, no real harm. |
IMHO, this is antithesis to passphrases and should not be merged. If some website allows the use of passphrases, but adds additional requirements like numbers etc, it would be better to satisfy those with fixed modifications, such as capitalizing the 1st letter or adding an easy to remember suffix like "123!". None of this adds security to the passphrase, it is only to satisfy the misguided requirements of those websites. Although most websites that I know don't even allow enough characters to use a passphrase at all. I would also disallow the use of multiple (random) separators, and stick to only one per passphrase. Btw, why is there a duplicate character count, both below the word case, and in the entropy status line? The latter is enough. |
How about this:
|
My personal reason for implementing this variant is that I often need easy-to-type, yet complex passwords that are stored in KeePassXC and that I can use on systems that do not have the keystore themselves. Random passwords are much more difficult to type with the same complexity. Frequently used, they are also usually easy to memorize. But that is not the primary goal of this implementation. |
How about both "MIXER" (I don't like that name) and "Capitalized" are added. I think MIXER is better named "MIXED case" |
b7dea0d
to
83ef077
Compare
I removed the code that picked from the list of separators, that isn't a desired behavior for passphrase generation. I also removed the extra character count display on the passphrase generator tab. |
83ef077
to
8ec7e6c
Compare
An additional approach to create passphrases with one random word being in UPPERCASE.
8ec7e6c
to
b1d4d7f
Compare
Description
Create passphrase using one UPPERCASE word in combination with lowercase words. Separator characters will be selected randomly out of the String provided by the user.
Screenshots
Testing strategy
A pattern based test is included in the TestPassphraseGenerator class.
Type of change