Reset splitter sizes on database unlock #11014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11014 +/- ##
===========================================
+ Coverage 63.72% 63.74% +0.02%
===========================================
Files 362 362
Lines 38002 38028 +26
===========================================
+ Hits 24215 24240 +25
- Misses 13787 13788 +1 ☔ View full report in Codecov by Sentry. |
droidmonkey
force-pushed
the
fix/splitter-issues
branch
from
ac96b79
to
0046bc1
Compare
droidmonkey
force-pushed
the
fix/splitter-issues
branch
from
0046bc1
to
b5f5106
Compare
droidmonkey
force-pushed
the
fix/splitter-issues
branch
2 times, most recently
from
bc67f2e
to
cb39275
Compare
phoerious
approved these changes
Aug 25, 2024
|
I want to write unit tests for this before I merge |
droidmonkey
force-pushed
the
fix/splitter-issues
branch
from
cb39275
to
e2f16dd
Compare
|
@phoerious can you take another look? I added a commit that disables collapsing the group view and instead adds a view menu action to explicitly show/hide the group view. The behavior is similar to the preview panel.
|
phoerious
approved these changes
Oct 21, 2024
* Attempt to avoid issue with splitters not being appropriately calculated because the main window isn't sized yet. This can happen if the main window is hidden when the database is loaded and the splitter sizes are not recorded in the config file.
* Prevent group pane from being hidden just by dragging. Introduce new View menu setting to hide the group pane. * Replace the preview panel "close" icon with a "collapse down" icon making the intention clearer. * Better organize the view menu
droidmonkey
force-pushed
the
fix/splitter-issues
branch
from
e2f16dd
to
f948a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve related splitter UX as well:
Testing strategy
Manual testing is pending...
Type of change