Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use secure temp directory for remote sync (#10911) #10914

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Use secure temp directory for remote sync (#10911) #10914

wants to merge 5 commits into from
+83 −29

Commits on Jun 17, 2024

  1. Fix use secure temp directory for remote sync (keepassxreboot#10911)

    @t-h-e
    t-h-e committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    5c865be View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Add error handling 

    in case directory could not be created or permissions could not be set
    @t-h-e
    t-h-e committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    52b6586 View commit details
    Browse the repository at this point in the history

  2. Update translations

    @t-h-e
    t-h-e committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    fc165f6 View commit details
    Browse the repository at this point in the history

  3. Use single instance of remote handler per sync 

    Pro:
- allows use of destructor to clean up
- remote handler can store file location and reuse it

Con:
- upload can not be called without previously calling download
  - currently not needed
    @t-h-e
    t-h-e committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2c03738 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Handle possible nullptr exception

    @t-h-e
    t-h-e committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b0fa6b5 View commit details
    Browse the repository at this point in the history