-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support opening remote databases #10896
Support opening remote databases #10896
Conversation
ea3edd2
to
2bc6afd
Compare
I'm not sure why this test fails in the CI on Ubuntu
Windows and Mac seem fine. Also tested locally in Windows and Manjaro and there, this test works as well... |
Could be a modal dialog open on Linux? Like a question or notice dialog. |
It would be nice to add the WebDav protocol inside this new feature. Instead of using a NextCloud client sync for example, the database would be accessible only from the server with an authentication. It would add a great feature for companies that want manage employees databases in a central server. |
@Hidigoudi WebDav can be setup in all major OS's natively as a mounted drive. You can use a third-party WebDav utility with the Remote Sync feature if you like. |
@Hidigoudi You can use the
Don't forget to change the username, password and the webdav server. |
@Maasea you can leave |
In am eagerly waiting for this for months now. Is there anything where we can help? |
Change ImportWizard usage in DatabaseTabWidget to use `show()` rather than `exec()`. Using `exec()` is discouraged in the QT documentation, as it can lead to bugs. `exec()` spins up another event loop, which also makes testing harder.
5b65092
to
f4f4e8a
Compare
This is great, fixed a regression with importing into an existing database. Couple things that could be done in future improvements to the code base:
You may be able to implement the second suggestion, but not sure if that would be merged properly in DatabaseTabWidget |
Failing tests seem unrelated to my changes |
Follow up to #7222
Adding an option to import a remote database. Import the data to a new database, existing database or a temporary database (see option "Temporary Database" in section "Import Into")
Screenshots
Testing strategy
Similar to syncing with a remote database, specify a download command and if necessary input to download the remote database.
Also added a unit test.
Type of change