Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several cases of incorrect handling of a Group/Entry's LastModification/Creation time #10481

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Fix several cases of incorrect handling of a Group/Entry's LastModification/Creation time #10481

wants to merge 12 commits into from
+219 −54

Commits on Mar 19, 2024

  1. Preserve the LastModificationTime when setting a group/entry previous… 

    … parent

Partially fixes keepassxreboot#8170 (for inter-db moves)
    vuurvlieg committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ff9f639 View commit details
    Browse the repository at this point in the history

  2. Improve drag & drop behavior 

    - Preserve the LastModificationTime for a group/entry cloned with the CloneResetTimeInfo flag
- Retain UUID's and timeInfo when moving group(s)/entry(s) between db's
- Prevent the Recycle Bin group from being moved to another db
- Cross-db moves that might require merge logic are not (yet) supported and show an error message instead

Fixes keepassxreboot#6202
Fixes keepassxreboot#8170
    vuurvlieg committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    0665a6c View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Tweak error messages

    vuurvlieg committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d644866 View commit details
    Browse the repository at this point in the history

  2. Tweak comments

    vuurvlieg committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9b6c36b View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Restore previous drag & drop logic

    vuurvlieg committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ebb2d88 View commit details
    Browse the repository at this point in the history

  2. Fix missed case of incorrect update to a Group's LastModificationTime

    vuurvlieg committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6a0a78b View commit details
    Browse the repository at this point in the history

  3. Correct overzealous refactor

    vuurvlieg committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0d3a3e9 View commit details
    Browse the repository at this point in the history

  4. Fix case of incorrect update to a Group's LastModificationTime

    vuurvlieg committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2a287f6 View commit details
    Browse the repository at this point in the history

  5. Add check to test case

    vuurvlieg committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ffb9b11 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Add and adjust test-cases

    vuurvlieg committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9a7db37 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Fix moving a group/entry across dbs resets the CreationTime

    vuurvlieg committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ca4ae86 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Fix additional cases of incorrectly handling of a Group's LastModific… 

    …ationTime

Cases:
- Entry is added to a Group
- Entry is removed from a Group
- The Group list is sorted
    vuurvlieg committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    22a1a82 View commit details
    Browse the repository at this point in the history