Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update docker build to include arm64 #7

Merged

Conversation

cwkang1998
Copy link

@cwkang1998 cwkang1998 commented Jun 19, 2023

Per title, add workflow to build for arm64, taking reference from madara's workflow.

linux/arm64 might work for Mac M1, but needs further testing.

Closes #1

@cwkang1998 cwkang1998 changed the title ci: update docker build to include arm and arm64 ci: update docker build to include arm64 Jun 19, 2023
@cwkang1998
Copy link
Author

Test workflow run, with ubuntu-latest instead of ubuntu-latest-32-cores:

Currently amd64 seems to build successfully but something is making arm64 extremely slow to build, investigating.

@cwkang1998
Copy link
Author

Successfully built it off CI on my local machine to amd64 and arm64, its slow on arm64 probably due to needing rebuilds on some dependencies for arm64.

@cwkang1998
Copy link
Author

Build took 2 hours, but its working https://github.com/cwkang1998/madara-app/actions/runs/5315748445/jobs/9624492972.

The attached example is failing due to the fact that it has no permission to push to the docker repository.

Copy link

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@AbdelStark AbdelStark merged commit b950307 into keep-starknet-strange:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants