Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSM Calldata Updates #192

Merged
merged 12 commits into from
Sep 11, 2024
Merged

MSM Calldata Updates #192

merged 12 commits into from
Sep 11, 2024

Conversation

raugfer
Copy link
Collaborator

@raugfer raugfer commented Sep 10, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Function msm_calldata_builder does not take any of the boolean options.

Issue Number: #189

What is the new behavior?

Adds support for msm_calldata_builder boolean options from JavaScript. Also adds support for risc0_mode option.

Does this introduce a breaking change?

  • Yes
  • No

Calls to msm_calldata_builder from JavaScript needs to pass in boolean options

@raugfer raugfer marked this pull request as ready for review September 11, 2024 16:41
feltroidprime
feltroidprime requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@feltroidprime feltroidprime left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job. Just handle the error with a Result, otherwise the wasm binding is extremely verbose in case of errors and prints dozens of pages to stdout if an assert! in rust fails...

tools/garaga_rs/src/msm.rs Outdated Show resolved Hide resolved
tools/garaga_rs/src/msm.rs Outdated Show resolved Hide resolved
@feltroidprime feltroidprime merged commit 2fb2964 into keep-starknet-strange:main Sep 11, 2024
26 checks passed
@raugfer raugfer deleted the msm-calldata-updates branch September 11, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feltroidprime feltroidprime feltroidprime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raugfer @feltroidprime