Add config as parameter to help validate scaler meta data #5819
Conversation
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
| @@ -46,7 +46,7 @@ type activeMQMetadata struct { | |||
| ActivationTargetQueueSize int64 `keda:"name=activationTargetQueueSize, order=triggerMetadata, optional, default=0"` | |||
| } | |||
|
|
|||
| func (a *activeMQMetadata) Validate() error { | |||
| func (a *activeMQMetadata) Validate(_ scalersconfig.ScalerConfig) error { | |||
There was a problem hiding this comment.
given there are currently two configs that implement Validate() and both would ignore this argument, I would like to wait for a little bit before merging the PR.
I understand it will be useful for #5808 but I think it makes sense for now to first see a few more configs refactored and then make a decision. If a good number of configs find it useful, then I'm happy to add it. But if it's just a handful of configs, then perhaps we can consider a different pattern for those that need it without putting restrictions on scaler configs that don't need it, wdyt?
There was a problem hiding this comment.
Sure. Let's wait for other scalers or find another way to do it.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed due to inactivity. |
|
I will reopen this as a reminder to continue the discussion |
stale
bot
removed
the
stale
There was a problem hiding this comment.
@SpiritZhou @wozniakjan what is the status of this, please?
|
imho, it's currently open for discussion, I will set it as a draft for now |
Add config as parameter in the Validator func so that we can move all validator into this func, such as checking some situation under config.AsMetricSource. #5808 (comment)
Checklist
Relates to # #5037