PR to resolve remaining warnings left in eslint #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
shellyear
force-pushed
the
fix/remaining-eslint-warnings
branch
from
b694788
to
39df32f
Compare
|
terminal after running npm run validate I suggest to solve the chunk size warning in a separate branch. Created issue for that 
|
shellyear
force-pushed
the
fix/remaining-eslint-warnings
branch
2 times, most recently
from
a91693e
to
1b0fd3d
Compare
blcham
requested changes
Mar 12, 2024
vite.config.js
Outdated
| @@ -14,6 +15,7 @@ export default defineConfig({ | |||
| eslintPlugin({ | |||
| cache: false, // disable eslint cache to avoid conflicts | |||
| }), | |||
| nodePolyfills(), | |||
There was a problem hiding this comment.
Are we able to describe what is the issue? We could reference not only issue but also what causes it
It seems that it is again related to lib parse-link-headers. We can discuss alternatives to this library. Maybe some fixed fork?
There was a problem hiding this comment.
again we need to reference here issue which we can watch to solve the issue
blcham
reviewed
Mar 13, 2024
blcham
reviewed
Mar 13, 2024
vite.config.js
Outdated
| @@ -14,6 +15,7 @@ export default defineConfig({ | |||
| eslintPlugin({ | |||
| cache: false, // disable eslint cache to avoid conflicts | |||
| }), | |||
| nodePolyfills(), | |||
There was a problem hiding this comment.
again we need to reference here issue which we can watch to solve the issue
blcham
reviewed
Mar 14, 2024
shellyear
force-pushed
the
fix/remaining-eslint-warnings
branch
2 times, most recently
from
4f27b91
to
f6ff982
Compare
blcham
reviewed
Mar 15, 2024
blcham
reviewed
Mar 15, 2024
blcham
reviewed
Mar 15, 2024
blcham
reviewed
Mar 15, 2024
blcham
reviewed
Mar 15, 2024
…plugin-node-polyfills package
…emove unused, unuofficial vite plugin
… for node.js 'url' package
shellyear
force-pushed
the
fix/remaining-eslint-warnings
branch
from
f7637c6
to
f34ba50
Compare
blcham
reviewed
Mar 15, 2024
blcham
reviewed
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There are no actual eslint errors remained, but the other ones described here