Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic description and stock #330

Merged
merged 2 commits into from
May 30, 2024

Conversation

Kasmadei
Copy link
Collaborator

@Kasmadei Kasmadei commented May 28, 2024

Resolves: #298
Resolves: #299

Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

public/locales/cs/translation.json Outdated Show resolved Hide resolved
public/locales/en/translation.json Outdated Show resolved Hide resolved
src/models/eventModel.tsx Outdated Show resolved Hide resolved
}, [shapeToolData]);

const basedFailureRate = shapeToolData?.supertypes?.supertypes?.hasFailureRate?.estimate?.value;
const requiredFailureRate = shapeToolData?.supertypes?.hasFailureRate?.requirement?.upperBound;

return (
<Box paddingLeft={2} marginRight={2}>
<FaultEventShapeToolPane data={shapeToolData} onEventUpdated={onEventUpdated} refreshTree={refreshTree} />
{/* Hidden to prevent app crush after root node select (Bug with UI). Will be fixed in next PR */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed from this PR

Copy link
Contributor

@blcham blcham May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kasmadei i did not see any issue for that so i created it, i thought you will create PR with this commit as temporal workaround for the issue -- #331

@blcham blcham merged commit 9fc4106 into kbss-cvut:main May 30, 2024
1 check passed
@blcham blcham deleted the feature/schematicDescription-and-stock branch May 30, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix stock property as it was moved in model Add schematic designation
2 participants