Merge pull request #314 from kbss-cvut/fix/302-fix-login-response-logic

login returns reject promise if login response indicates authentication failed
kbss-cvut · May 20, 2024 · c202b46 · c202b46
2 parents 973c9d8 + 5f4b633
commit c202b46
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/services/userService.tsx b/src/services/userService.tsx
@@ -33,12 +33,14 @@ export const login = async (loginRequest: UserLoginRequest): Promise<UserLoginRe
     const response = await axiosClient.post<UserLoginResponse>("/auth/signin", loginRequest, {
       headers: { "Content-type": AUTH },
     });
-
-    return response.data;
+    if (response.data.success || response.data.loggedIn) {
+      return response.data;
+    }
+    return Promise.reject(response.data.errorMessage);
   } catch (e) {
     console.log("Failed to call /login");
     const defaultMessage = "Login failed";
-    return new Promise((resolve, reject) => reject(handleServerError(e, defaultMessage)));
+    return Promise.reject(handleServerError(e, defaultMessage));
   }
 };