Add support for missing cell reference #10

velios · 2023-11-12T19:38:24Z

No description provided.

test/core_test.clj

src/bb_excel/core.clj

velios · 2023-11-12T19:46:08Z

src/bb_excel/core.clj

-(def tags
-  "Map of Excel XML namespaces of interest"
-  {:sheet-tag  #{:sheets
-                 :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/sheets
-                 :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/sheets}
-   :row-tag    #{:row
-                 :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/row
-                 :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/row}
-   :text-part   #{:si
-                  :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/si
-                  :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/si}
-   :numFmts   #{:numFmts
-                :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/numFmts
-                :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/numFmts}
-   :cellxfs   #{:cellXfs
-                :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/cellXfs
-                :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/cellXfs}
-   :xf   #{:xf
-           :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/xf
-           :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/xf}
-   :text-t   #{:t
-               :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/t
-               :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/t}
-   :text-r   #{:r
-               :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/r
-               :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/r}
-   :sheet-data #{:sheetData
-                 :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2Fspreadsheetml%2F2006%2Fmain/sheetData
-                 :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2Fspreadsheetml%2Fmain/sheetData}
-   :sheet-id   #{:id
-                 :xmlns.http%3A%2F%2Fschemas.openxmlformats.org%2FofficeDocument%2F2006%2Frelationships/id
-                 :xmlns.http%3A%2F%2Fpurl.oclc.org%2Fooxml%2FofficeDocument%2Frelationships/id}})


With namespace-aware arg of (xml/parse styles {:namespace-aware false}) and by-tag pred in util ns i thought we can avoid verbose tag description

src/bb_excel/core.clj

velios · 2023-11-12T19:53:12Z

src/bb_excel/core.clj

  [^ZipFile zipfile]
-  (if-let [wb (.getEntry zipfile "xl/styles.xml")]
-    (let [ins (.getInputStream zipfile wb)
-          x   (parse-str (slurp ins))]


Change here and next slurp to .getInputStream for optimal memory usage

src/bb_excel/core.clj

velios · 2023-11-12T19:56:34Z

src/bb_excel/core.clj

+(defn number->column-letter
+  [n]
+  (loop [num n
+         acc ""]
+    (if (> num 0)
+      (let [residue (mod (dec num) 26)
+            new-num (quot (dec num) 26)]
+        (recur new-num (str (char (+ residue A_CHAR_INDEX)) acc)))
+      acc)))


With this functionality can add new option to retrieve rows with number cell index If this may be of interest to anyone

velios

After PR work faster in my test one colum file with 1048576 rows, like 25% of perfomance rise

wip fix fix fix fix fix fix fix fix fix fix fix fix fix

src/bb_excel/core.clj

velios

Question about current functionality