Update consistency calculation #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the scripts fail because imports have been commented out. This commit uncomments the imports.
…rash In an older version of the code, Cell in pysheaf.py had the attribute mExtendedAssignmentConsistancyWeightDivisor that was defaulted to 2.0. In the new version, it's replaced with mExtendedAssignmentConsistancyWeight that's defaulted to None. As a result, running Cell 8 in SheafBuildingExample.ipynb would lead to a norm being computed on an empty array in Line 181 of pysheaf.py in ComputeConsistency() and would cause a crash. This commit assigns mExtendedAssignmentConsistancyWeight=0.5 to reproduce the original behavior of the notebook.
If the mExtendedAssignmentConsistancyWeight is not changed from its default of None, the code may crash because it may attempt to compute a norm on an empty array. This commit updates the code to avoid this behavior.
mszulcz-mitre
changed the title
|
@kb1dds : I ran some tests and am thinking that the code in this PR isn't sufficient to address the issue. In the current version of the |
|
This is something I tossed around a bit, and haven't found a totally
satisfactory answer. Regardless, this behavior is why my recommended
approach is to put an assignment on *every* cell. With the current
behavior (unless I've messed up, which is possible), leaving assignments
off cells should be equivalent to computing the local consistency radius on
an open subset that only includes the cells with an assignment. That seems
like a sensible default to me. Do you agree?
…On Wed, Sep 25, 2024 at 10:04 PM mszulcz-mitre ***@***.***> wrote:
@kb1dds <https://github.com/kb1dds> : I ran some tests and am thinking
that the code in this PR isn't sufficient to address the issue. In the
current version of the pysheaf.py--including the version in this PR--the
default of None for mExtendedAssignmentConsistancyWeight causes
consistencies to not be calculated by default unless a cell has an
assignment. Is that your desired behavior?
—
Reply to this email directly, view it on GitHub
<#36 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAITCGJUFHDEUCIQQQ46Q4LZYNTSHAVCNFSM6AAAAABOZPO5TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZVGYYDGNRRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses Issue #34.
To recreate the problems it addresses:
SheafBuildingExample.ipynb. Cell 8 should crash.linearSheafExample.py. The script should fail due to import errors.